Bug 234440

Summary: math/clrng: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Johannes M Dieterich <jmd>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, pkubaj
Priority: --- Flags: bugzilla: maintainer-feedback? (jmd)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Piotr Kubaj freebsd_committer 2018-12-27 10:57:14 UTC
Created attachment 200554 [details]
patch

Building with GCC requires adding -Wno-expansion-to-defined to CFLAGS.

src/library/../cl/include/private/Random123/features/compilerfeatures.h:265:5: error: this use of "defined" may not be portable [-Wexpansion-to-defin
ed]
 #if R123_USE_CXX11_CONSTEXPR
     ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/library/../cl/include/private/philox432.c.h:41,
                 from src/library/philox432.c:51:


Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer 2018-12-28 21:32:59 UTC
A commit references this bug:

Author: jmd
Date: Fri Dec 28 21:32:12 UTC 2018
New revision: 488629
URL: https://svnweb.freebsd.org/changeset/ports/488629

Log:
  math/clrng: fix with GCC based architectures

  PR:	234440
  Submitted by:	Piotr Kubaj

Changes:
  head/math/clrng/Makefile
Comment 2 Johannes M Dieterich freebsd_committer 2018-12-28 21:34:06 UTC
Applied, thanks!