Bug 234530

Summary: net/kea: libkea-pgsql.so.0 not installed when PGSQL selected
Product: Ports & Packages Reporter: Matt Smith <freebsd>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Some People CC: hrs, pi
Priority: --- Flags: koobs: maintainer-feedback? (hrs)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-for-pqsql-mysql pi: maintainer-approval?

Description Matt Smith 2018-12-31 14:05:01 UTC
In the latest 1.5.0 update when PGSQL support is selected the binaries get linked against libkea-pgsql.so.0 but this is not installed. As a result this happens:

# ldd `which kea-dhcp4` | grep 'not found'
libkea-pgsql.so.0 => not found (0)

# service kea onestart
Starting kea.                                                                                              
INFO/keactrl: Starting /usr/local/sbin/kea-dhcp4 -c /usr/local/etc/kea/kea-dhcp4.conf                      
ld-elf.so.1: Shared object "libkea-pgsql.so.0" not found, required by "kea-dhcp4"                          
INFO/keactrl: Starting /usr/local/sbin/kea-dhcp6 -c /usr/local/etc/kea/kea-dhcp6.conf                      
ld-elf.so.1: Shared object "libkea-pgsql.so.0" not found, required by "kea-dhcp6"     

It doesn't look like this file is mentioned in the pkg-plist file. My thoughts are that there should be some conditional entries in that file if you have other options for databases selected?
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-31 14:09:59 UTC
CC committer of 1.5.0 update (ports r488724)
Comment 2 Kurt Jaeger freebsd_committer 2018-12-31 14:28:38 UTC
Thank, I'll look into it. I guess it did not work in the old version, either, because there's no libkea-pgsql in the pkg-plist either.
Comment 3 Kurt Jaeger freebsd_committer 2018-12-31 15:05:41 UTC
Created attachment 200660 [details]
patch-for-pqsql-mysql

Please test this patch.
Comment 4 Kurt Jaeger freebsd_committer 2018-12-31 16:36:16 UTC
Committed.
Comment 5 commit-hook freebsd_committer 2018-12-31 16:36:48 UTC
A commit references this bug:

Author: pi
Date: Mon Dec 31 16:36:04 UTC 2018
New revision: 488800
URL: https://svnweb.freebsd.org/changeset/ports/488800

Log:
  net/kea: unbreak if PGSQL or MYSQL is selected

  PR:		234530
  Reported by:	Matt Smith <matt.xtaz@gmail.com>
  Approved by:	hrs (well, sortof)

Changes:
  head/net/kea/Makefile
  head/net/kea/pkg-plist