Bug 234562
| Summary: | sysutils/smartmontools: Update to 7.0 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Oleksii Samorukov <samm> | ||||||||
| Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | nevecherya, pi, samm, swills | ||||||||
| Priority: | --- | Keywords: | needs-patch, needs-qa | ||||||||
| Version: | Latest | Flags: | samm:
maintainer-feedback+
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 200702 [details]
update to 7.0
This builds on 11.2 but fails to build on 12.0 and HEAD with:
c++ -DHAVE_CONFIG_H -I. -DBUILD_INFO='"(local build)"' -DSMARTMONTOOLS_SYSCONFDIR='"/usr/local/etc"' -DSMARTMONTOOLS_SMARTDSCRIPTDIR='"/usr/local/etc"' -DSMARTMONTOOLS_DRIVEDBDIR='"/usr/local/share/smartmontools"' -O2 -pipe -fstack-protector -fno-strict-aliasing -Wall -W -Wformat=2 -c -o smartctl.o smartctl.cpp
os_freebsd.cpp:545:42: error: member reference base type 'uint16_t' (aka 'unsigned short') is not a structure or union
uint16_t nvme_status = ((cp_p->status.sct << 8) | cp_p->status.sc) & 0x3ff;
~~~~~~~~~~~~^~~~
os_freebsd.cpp:545:67: error: member reference base type 'uint16_t' (aka 'unsigned short') is not a structure or union
uint16_t nvme_status = ((cp_p->status.sct << 8) | cp_p->status.sc) & 0x3ff;
~~~~~~~~~~~~^~~
2 errors generated.
Thank you. I will test port in the FreeBSD 12 to fix the issues. Created attachment 201461 [details]
update to 7.0 and fix build on FBSD 12
Updated patch with FBSD 12 support
A commit references this bug: Author: swills Date: Thu Jan 31 12:37:46 UTC 2019 New revision: 491711 URL: https://svnweb.freebsd.org/changeset/ports/491711 Log: sysutils/smartmontools: update to 7.0 PR: 234562 Submitted by: samm@os2.kiev.ua (maintainer) Changes: head/sysutils/smartmontools/Makefile head/sysutils/smartmontools/distinfo head/sysutils/smartmontools/files/patch-configure head/sysutils/smartmontools/files/patch-freebsd__nvme__ioctl.h head/sysutils/smartmontools/files/patch-os__freebsd.cpp head/sysutils/smartmontools/files/patch-update-smart-drivedb.in Committed, thanks! |
Created attachment 200700 [details] update to 7.0 - Update to 7.0 release - Remove unrelevant patches - Use fetch as default download tool