Bug 234586
| Summary: | www/foswiki: Add missing dependencies. Fix permissions and environment path | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sam Chen <sc.gear> | ||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||
| Severity: | Affects Many People | CC: | portmaster | ||||||||||||||||
| Priority: | --- | Keywords: | needs-qa | ||||||||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(portmaster) koobs: merge-quarterly? |
||||||||||||||||
| Hardware: | Any | ||||||||||||||||||
| OS: | Any | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
Created attachment 200728 [details]
Patch to Makefile
Created attachment 200729 [details]
Patch to bsd.foswiki.mk
Created attachment 200730 [details]
Patch to pkg-message-noapache.in
Created attachment 200731 [details]
New patch-tools_fix_file_permissions.sh
Created attachment 200733 [details]
New pkg-install.in
I've coded/noted the manual tweaks in my local foswiki port Makefile set. Patches to files are attached. It builds from scratch, locally just fine. But please review the changes carefully, since I'm new at this FreeBSD code lingo. Thanks. Thank you for the report and patches Sam If you could combine all the patches to the port (www/foswiki/*) into a single unified diff that would be great. For any patches to the foswiki source code (such as tools/fix_file_permissions.sh), these need to take the form of an addition of a patch-* file to the files/ port directory. You can do this using the 'makepatch' target which will automatically create them in the right place/format. For instructions see: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#slow-patch Basically: 1) make patch 2) cd to the WRKSRC dir where the sources are extracted 3) cp <file> <file>.orig 4) make changes to <file> 5) go back to the port dir and `make makepatch` This will produce a files/patch-* file for each <file> <file>.orig combination in the WRKSRC dir Good eyesight, Kubilay. Your comment on 'makepath' target and link to the Porter's Handbook is very helpful. Thank you. Please find attached the single file with all patches. Created attachment 200759 [details]
Patch set for www/foswiki
(In reply to Sam Chen from comment #8) You're welcome Sam and thank you for updating those patches. A commit references this bug: Author: swills Date: Sat Jan 26 12:40:46 UTC 2019 New revision: 491274 URL: https://svnweb.freebsd.org/changeset/ports/491274 Log: www/foswiki: cleanup * Add missing dependencies * Fix permissions PR: 234586 Submitted by: Sam Chen <sc.gear@one.caeon.com> Approved by: maintainer timeout (portmaster@bsdforge.com, >2 weeks) Changes: head/www/foswiki/Makefile head/www/foswiki/bsd.foswiki.mk head/www/foswiki/files/patch-tools_fix__file__permissions.sh head/www/foswiki/files/pkg-install.in head/www/foswiki/files/pkg-message-noapache.in Committed, thanks! |
Created attachment 200727 [details] Output from scripts and note The current foswiki-2.1.6 port needs a few manual tweaks to function. Here are issues that revealed while following the foswiki.org/System/InstallGuide: * Missing dependencies reported by the "tools/configure -check" script, and in Wiki configure page. * FreeBSD specific option needs to be set in "tools_fix_file_permissions.sh". * Ownership of /usr/local/www/foswiki should be www:www to allow writes. * An Apache 2.4 config need to be generated, since FreeBSD port apache22 is EOL.