Bug 234607

Summary: devel/gitg: Crash on exit if built with -fstack-protector-all
Product: Ports & Packages Reporter: rozhuk.im
Component: Individual Port(s)Assignee: Koop Mast <kwm>
Status: Closed FIXED    
Severity: Affects Some People CC: rozhuk.im
Priority: --- Keywords: crash, easy, needs-qa
Version: LatestFlags: kwm: merge-quarterly-
Hardware: Any   
OS: Any   
URL: https://gitlab.gnome.org/GNOME/gitg/issues/171
Attachments:
Description Flags
patch
none
update patch rozhuk.im: maintainer-approval?

Description rozhuk.im 2019-01-04 10:42:09 UTC
Created attachment 200763 [details]
patch

gitg: crash on exit if build with -fstack-protector-all
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-04 10:47:40 UTC
Thank you for the report and patch (and reporting it upstream)

Could you please include upstream references in the patch header as a comment:

# gitg crash on exit if built with -fstack-protector-all
# https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234607
# https://gitlab.gnome.org/GNOME/gitg/issues/171
Comment 2 rozhuk.im 2019-01-04 12:09:00 UTC
Created attachment 200764 [details]
update patch
Comment 3 rozhuk.im 2019-02-11 14:03:53 UTC
ping
Comment 4 commit-hook freebsd_committer 2019-02-24 15:37:18 UTC
A commit references this bug:

Author: kwm
Date: Sun Feb 24 15:36:34 UTC 2019
New revision: 493768
URL: https://svnweb.freebsd.org/changeset/ports/493768

Log:
  Fix a crash on exit if build with -fstack-protector-all.

  PR:		234607
  Submitted by:	rozhuk.im@gmail.com

Changes:
  head/devel/gitg/Makefile
  head/devel/gitg/files/
  head/devel/gitg/files/patch-libgitg_gitg-repository-list-box.vala