Bug 234639

Summary: www/py-djangorestframework: Update to 3.9.0
Product: Ports & Packages Reporter: Kai Knoblich <kai>
Component: Individual Port(s)Assignee: Martin Wilke <miwi>
Status: Closed FIXED    
Severity: Affects Only Me CC: miwi, python, ultima
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://www.django-rest-framework.org/community/release-notes/#39x-series
Attachments:
Description Flags
py-djangorestframework-3.9.0.patch
kai: maintainer-approval+
py-djangorestframework-3.9.0-copies-as-adds.patch
kai: maintainer-approval+
py-djangorestframework-3.9.0-rev1.patch kai: maintainer-approval+

Description Kai Knoblich freebsd_committer freebsd_triage 2019-01-05 17:06:03 UTC 
Created attachment 200801 [details]
py-djangorestframework-3.9.0.patch

Hello,

attached is the patch that updates www/py-djangorestframework to 3.9.0 and does also the following:

- Copies the 3.8.2 version of www/py-djangorestframework to www/py-djangorestframework82
- Updates CONFLICTS_INSTALL entries of www/py-djangorestframework36 and www/py-djangorestframework38

Changes by upstream:
- https://www.django-rest-framework.org/community/release-notes/#39x-series

QA:
~~~
- poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r341993 amd64 + i386) for each py27 + py36 flavor -> OK
- portlint -> OK


Note:
Attached are two variants of the patch - one created with "svn diff" and the other one created with "svn diff --show-copies-as-adds" to make testing somewhat easier.
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2019-01-05 17:07:04 UTC 
Created attachment 200802 [details]
py-djangorestframework-3.9.0-copies-as-adds.patch
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2019-01-05 22:54:32 UTC 
CC'ing ultima@ who is maintainer of www/seahub that depends on www/py-djangorestframework .

www/seahub builds find with the new version of www/py-djangorestframework but it might be an good idea to do some runtime tests.
Comment 3 Richard Gallamore freebsd_committer freebsd_triage 2019-01-11 19:43:09 UTC 
The main branch works fine on SeaHub with the update applied.

I'm not sure if there is another reason why a 38 branch is being created, but it may not be necessary. I believe the only reason why the 36 branch exists is for applications that require an older version of Django that the main branch doesn't support.

If you don't have a reason for the 38 branch, it is probably safe to say a new branch shouldn't be created.
Comment 4 Kai Knoblich freebsd_committer freebsd_triage 2019-01-12 15:14:11 UTC 
Created attachment 201063 [details]
py-djangorestframework-3.9.0-rev1.patch
Comment 5 Kai Knoblich freebsd_committer freebsd_triage 2019-01-12 15:32:08 UTC 
(In reply to Richard Gallamore from comment #3)

Thank you for testing www/py-djangorestframework with Seahub and for your suggestions.

Creating a new branch is not really necessary and was intended as fallback if some ports had problems with the new version.

The www/py-djangorestframework36 is a remainder when www/py-django18 was still in the ports tree. Now that Django 1.8 is gone, there's imho no particular reason to keep www/py-djangorestframework36.

Attached is a revised version of the patch that only updates www/py-djangorestframework .
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-01-29 16:37:53 UTC 
A commit references this bug:

Author: miwi
Date: Tue Jan 29 16:36:54 UTC 2019
New revision: 491584
URL: https://svnweb.freebsd.org/changeset/ports/491584

Log:
  - Update to 3.9.0

  Changes by upstream:
  - https://www.django-rest-framework.org/community/release-notes/#39x-series

  PR:		234639
  Submitted by:	maintainer
  Sponsored by:	iXsystems Inc.

Changes:
  head/www/py-djangorestframework/Makefile
  head/www/py-djangorestframework/distinfo
  head/www/py-djangorestframework/pkg-descr