Bug 234651
| Summary: | math/scilab not buildable without GUI option | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Don Lewis <truckman> | ||||
| Component: | Individual Port(s) | Assignee: | Don Lewis <truckman> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Keywords: | needs-qa, patch | ||||
| Priority: | --- | Flags: | makc:
maintainer-feedback+
koobs: merge-quarterly? |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Comment on attachment 200823 [details]
patch to unbreak scilab build without GUI
Approved by: portmgr (blanket: build/run/package fix)
Approved by: koobs (ports)
Pending QA
@Don Feel free to assign yourself to commit/merge (MFH) if this passes QA (poudriere)
Successfully builds in puudriere on all supported releaaes as well as recent 13.0-CURRENT on i386 and amd64 both with and without the GUI option. A commit references this bug: Author: truckman Date: Tue Jan 8 17:51:14 UTC 2019 New revision: 489729 URL: https://svnweb.freebsd.org/changeset/ports/489729 Log: Make USES=gl conditional on the GUI option to unbreak build when GUI is disabled. Error was: scilab-5.5.2_15 need to specify gl component with USE_GL. because USE_GUI is conditional on GUI. While here, tweak Makefile statement ordering to reduce portlint warnings. PR: 234651 Approved by: makc (maintainer) MFH: 2019Q1 Changes: head/math/scilab/Makefile A commit references this bug: Author: truckman Date: Tue Jan 8 18:05:51 UTC 2019 New revision: 489730 URL: https://svnweb.freebsd.org/changeset/ports/489730 Log: MFH: r489729 Make USES=gl conditional on the GUI option to unbreak build when GUI is disabled. Error was: scilab-5.5.2_15 need to specify gl component with USE_GL. because USE_GL is conditional on GUI. While here, tweak Makefile statement ordering to reduce portlint warnings. PR: 234651 Approved by: makc (maintainer) Approved by: portmgr (blanket: build fix) Changes: _U branches/2019Q1/ branches/2019Q1/math/scilab/Makefile |
Created attachment 200823 [details] patch to unbreak scilab build without GUI If the GUI option is not enabled, then the scilab build fails check-sanity: =======================<phase: check-sanity >============================ ===> scilab-5.5.2_15 need to specify gl component with USE_GL. *** Error code 1 Fix by making USES=gl conditional on the GUI option. While here, tweak Makefile statement ordering to reduce portlint warnings.