Bug 234700
| Summary: | cad/opencascade: Do not set VIS_CMAKE_ON twice | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tobias Kortkamp <tobik> | ||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | thierry | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | tobik:
maintainer-feedback-
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: tobik Date: Mon Jan 21 06:09:01 UTC 2019 New revision: 490820 URL: https://svnweb.freebsd.org/changeset/ports/490820 Log: cad/opencascade: Do not set VIS_CMAKE_ON twice Given no feedback to the contrary do the most sensible thing and merge the two VIS_CMAKE_ON together. PR: 234700 Approved by: thierry (maintainer timeout, 2 weeks) Changes: head/cad/opencascade/Makefile (In reply to commit-hook from comment #1) Thanks! I did not find the time to check that. |
Created attachment 200879 [details] cad__opencascade.diff The port specifies VIS_CMAKE_ON twice like this VIS_CMAKE_ON= -DUSE_FREEIMAGE:BOOL=ON -DUSE_GL2PS:BOOL=ON \ -DUSE_FREETYPE:BOOL=ON [...] VIS_CMAKE_ON= -D3RDPARTY_FREETYPE_DIR=${LOCALBASE} The second VIS_CMAKE_ON overwrites the earlier one. Should the values be concatenated or can the first VIS_CMAKE_ON be removed? The attached patch concatenates them and also switches things to using the opt_CMAKE_BOOL options helper which is a little easier to read.