Bug 234704
| Summary: | x11-toolkits/p5-Tk: Do not set CONFIGURE_ARGS twice | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tobias Kortkamp <tobik> | ||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | pi | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | pi:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Committed, thanks! A commit references this bug: Author: pi Date: Mon Jan 7 19:27:30 UTC 2019 New revision: 489609 URL: https://svnweb.freebsd.org/changeset/ports/489609 Log: x11-toolkits/p5-Tk: Do not set CONFIGURE_ARGS twice The port currently sets CONFIGURE_ARGS twice. The second CONFIGURE_ARGS= overwrites the first, therefore X11INC and X11LIB are not in CONFIGURE_ARGS. The ports builds anyway, so the first CONFIGURE_ARGS can be removed. PR: 234704 Submitted by: tobik Changes: head/x11-toolkits/p5-Tk/Makefile |
Created attachment 200882 [details] x11-toolkits__p5-Tk.diff The port currently sets CONFIGURE_ARGS twice like this CONFIGURE_ARGS= X11INC=${LOCALBASE}/include X11LIB=${LOCALBASE}/lib [...] .if ${PORT_OPTIONS:MXFT} CONFIGURE_ARGS= XFT=1 USE_XORG+= xft .else CONFIGURE_ARGS= XFT=0 .endif Since the second CONFIGURE_ARGS= overwrites the first, X11INC and X11LIB are not in CONFIGURE_ARGS. The port builds fine anyway, so I think the first line should be removed for clarity's sake.