Bug 234736

Summary: math/reduce, math/reduce-psl: Do not set CONFIGURE_ARGS twice
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Pedro F. Giffuni <pfg>
Status: Closed FIXED    
Severity: Affects Only Me CC: pfg
Priority: --- Keywords: patch
Version: LatestFlags: pfg: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
math__reduce.diff tobik: maintainer-approval? (pfg)

Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-08 11:02:33 UTC 
Created attachment 200908 [details]
math__reduce.diff

The first CONFIGURE_ARGS is being overwritten by the second one.  Since the
build appears to succeed anyway there seems to be little point in keeping it.

Also removes WRKSRC since it is set to ${WRKDIR}/${DISTNAME} by default already.
Comment 1 Pedro F. Giffuni freebsd_committer freebsd_triage 2019-01-08 15:13:54 UTC 
Approved, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-08 15:23:43 UTC 
A commit references this bug:

Author: tobik
Date: Tue Jan  8 15:22:53 UTC 2019
New revision: 489704
URL: https://svnweb.freebsd.org/changeset/ports/489704

Log:
  math/reduce{,-psl}: Drop unused variables

  WRKSRC is set to the default value, CONFIGURE_ARGS is overwritten
  later and is not needed.

  PR:		234736
  Approved by:	pfg (maintainer)

Changes:
  head/math/reduce/Makefile
  head/math/reduce-psl/Makefile
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-08 15:24:04 UTC 
Committed. Thanks! :)