Bug 234758
| Summary: | [PATCH] devel/radare2: upgrade to 3.2.0, fix misbuilt script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Maciej Pasternacki <maciej> | ||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | mizhka, pi | ||||
| Priority: | --- | Flags: | mizhka:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Hi,
Thank you for patch!!!
Generally speaking I'm totally fine with patch. To avoid creating backup file, we can use ${SED} -i'' instead of ${REINPLACE_CMD}.
So it's up to port committer what is the best way to handle it (post-patch or SED). I have no preference.
@Ports committers,
Please have a look on ticket.
Thank!
Committed, thanks! A commit references this bug: Author: pi Date: Thu Jan 10 19:33:22 UTC 2019 New revision: 489890 URL: https://svnweb.freebsd.org/changeset/ports/489890 Log: devel/radare2: update 3.1.0 -> 3.2.0 PR: 234758 Submitted by: Maciej Pasternacki <maciej@pasternacki.net> Approved by: Michael Zhilin <mizhka@gmail.com> (maintainer) Relnotes: https://github.com/radare/radare2/releases/tag/3.2.0 Changes: head/devel/radare2/Makefile head/devel/radare2/distinfo head/devel/radare2/pkg-plist |
Created attachment 200921 [details] radare2-3.2.0.patch Upgraded to newest version. Fixed build issue where a script was generated from all files in the directory, including Makefile.bak left there by pathfix.