Bug 234819

Summary: net-im/licq-qt-gui: Remove qt5-buildtools run dependency
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Dirk Meyer <dinoex>
Status: Closed FIXED    
Severity: Affects Only Me CC: dinoex
Priority: --- Keywords: patch
Version: LatestFlags: dinoex: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
licq-qt-gui.diff tobik: maintainer-approval? (dinoex)

Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-10 11:53:12 UTC 
Created attachment 200983 [details]
licq-qt-gui.diff

I've also send this as a message on ports-committers, but I am filing
this PR so that it is not lost.

Message was about the switch to Qt 5 in ports r489554:

"Is adding qt5-buildtools (moc and rcc) as a run dependency intentional,
or should this have USE_QT=buildtools_build instead, similar to the
Qt 4 version with USE_QT=moc_build rcc_build?"

I do not see any evidence that qt5-buildtools is needed at runtime,
so I am attaching a patch that removes it.

It also fixes the following QA warning:

/!\ licq-qt-gui-1.9.0: Makefile warnings, please consider fixing /!\

You are using USE_GITHUB and WRKSRC is set which is wrong.  Set GH_PROJECT
correctly, set WRKSRC_SUBDIR or remove WRKSRC entirely.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-01-19 07:21:16 UTC 
A commit references this bug:

Author: dinoex
Date: Sat Jan 19 07:21:04 UTC 2019
New revision: 490709
URL: https://svnweb.freebsd.org/changeset/ports/490709

Log:
  - reduce runtime dependencies
  PR:		234819
  Submitted by:	tobik

Changes:
  head/net-im/licq-qt-gui/Makefile
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-19 14:25:06 UTC 
Thank you.