Summary: | pf: pfr_update_stats: assertion failed. | ||
---|---|---|---|
Product: | Base System | Reporter: | Ivan Rozhuk <rozhuk.im> |
Component: | kern | Assignee: | freebsd-pf (Nobody) <pf> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | CC: | kp, pi, rozhuk.im, zarychtam |
Priority: | --- | ||
Version: | 12.0-STABLE | ||
Hardware: | Any | ||
OS: | Any |
Description
Ivan Rozhuk
2019-01-11 15:19:28 UTC
Can you provide some more information on your setup? (i.e. network configuration, pf rules, ...) This had previously been reported, but then it appeared to be the result of a configuration problem: https://lists.freebsd.org/pipermail/freebsd-pf/2018-June/008841.html I don't yet fully understand the conditions that trigger this log, so I need more information. if ((ke == NULL || ke->pfrke_not) != notrule) { if (op_pass != PFR_OP_PASS) printf("pfr_update_stats: assertion failed.\n"); op_pass = PFR_OP_XPASS; } if (op_pass != PFR_OP_PASS && V_pf_status.debug >= PF_DEBUG_MISC) Probably good fix. (In reply to Kristof Provost from comment #1) All info in private email, if you need more - I will send. (In reply to Kristof Provost from comment #1) It was not a problem in the configuration but a problem that a specific configuration triggered this. I have tuned my configuration to avoid this. +1 for no more flooding kernel message buffer with this debug information. A commit references this bug: Author: kp Date: Tue Jan 15 08:59:52 UTC 2019 New revision: 343041 URL: https://svnweb.freebsd.org/changeset/base/343041 Log: pf: silence a runtime warning Sometimes, for negated tables, pf can log 'pfr_update_stats: assertion failed'. This warning does not clarify anything for users, so silence it, just as OpenBSD has. PR: 234874 MFC after: 1 week Changes: head/sys/netpfil/pf/pf_table.c A commit references this bug: Author: kp Date: Tue Jan 22 01:07:19 UTC 2019 New revision: 343289 URL: https://svnweb.freebsd.org/changeset/base/343289 Log: MFC r343041 pf: silence a runtime warning Sometimes, for negated tables, pf can log 'pfr_update_stats: assertion failed'. This warning does not clarify anything for users, so silence it, just as OpenBSD has. PR: 234874 Changes: _U stable/12/ stable/12/sys/netpfil/pf/pf_table.c A commit references this bug: Author: kp Date: Tue Jan 22 01:07:20 UTC 2019 New revision: 343290 URL: https://svnweb.freebsd.org/changeset/base/343290 Log: MFC r343041 pf: silence a runtime warning Sometimes, for negated tables, pf can log 'pfr_update_stats: assertion failed'. This warning does not clarify anything for users, so silence it, just as OpenBSD has. PR: 234874 Changes: _U stable/11/ stable/11/sys/netpfil/pf/pf_table.c |