Bug 234944

Summary: sysutils/pefs-kmod version 2018.11.26 fails to build on 10.4-STABLE
Product: Ports & Packages Reporter: shersch
Component: Individual Port(s)Assignee: Gleb Kurtsou <gleb>
Status: Closed FIXED    
Severity: Affects Many People CC: diizzy, w.schwarzenfeld
Priority: --- Flags: bugzilla: maintainer-feedback? (gleb)
Version: Latest   
Hardware: Any   
OS: Any   

Description shersch 2019-01-14 14:55:24 UTC
Fails to build on FreeBSD 10 because of missing function explicit_bzero in library strings.h (The explicit_bzero() function first appeared in OpenBSD 5.5 and FreeBSD 11.0.).

cc -O2 -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-2018-12-29/sys/modules/pefs/../../ -I. -I@ -I@/contrib/altq -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer   -mno-aes -mno-avx -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -Qunused-arguments  -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option  -Wno-error-tautological-compare -Wno-error-empty-body  -Wno-error-parentheses-equality -Wno-error-unused-function    -c /wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-2018-12-29/sys/modules/pefs/../../fs/pefs/pefs_subr.c -o pefs_subr.o
/wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-2018-12-29/sys/modules/pefs/../../fs/pefs/pefs_subr.c:129:2: error: implicit declaration of function 'explicit_bzero' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        explicit_bzero(mem, size);
        ^
1 error generated.
*** Error code 1
Comment 1 Gleb Kurtsou freebsd_committer freebsd_triage 2019-01-16 03:53:11 UTC
https://github.com/glk/pefs/commit/2443ebfaeed043ee5165fd44eafba7cf8c3c230a
disables explicit_bzero for older FreeBSD versions.

Please check if commit resolves the issue. I'll update port with new version afterwards.
Comment 2 shersch 2019-01-16 11:23:38 UTC
(In reply to Gleb Kurtsou from comment #1)
Yes, this resolves the issue. Thanks.
Comment 3 Walter Schwarzenfeld freebsd_triage 2019-08-04 19:03:23 UTC
ping!