|Summary:||[PATCH] dns/dsc remove net/GeoIP dependency and undeprecate|
|Product:||Ports & Packages||Reporter:||Craig Leres <leres>|
|Component:||Individual Port(s)||Assignee:||Craig Leres <leres>|
|Severity:||Affects Only Me||CC:||adamw, freebsd|
Description Craig Leres 2019-01-14 17:28:35 UTC
net/GeoIP has been deprecated but there is no need to deprecate dns/dsc since it builds without GeoIP support.
Comment 2 Craig Leres 2019-02-02 22:01:51 UTC
Created attachment 201658 [details] revised patch Here is a revised patch: - Add a dependency on net/libmaxminddb and retain GeoIP support - Remove pkg-descr whitespace flagged by portlint - Update pkg-message to describe updating via net/geoipupdate
Comment 3 Leo Vandewoestijne 2019-02-12 10:07:55 UTC
Awesome, I almost submitted another patch when I suddenly notice this one! Let me please test in the next few hours, but it looks better than what I had in mind, so great!
Comment 4 Leo Vandewoestijne 2019-02-12 13:45:50 UTC
Comment on attachment 201658 [details] revised patch All perfectly fine. Nice! Thanks.
Comment 5 commit-hook 2019-02-13 01:01:44 UTC
A commit references this bug: Author: leres Date: Wed Feb 13 01:01:13 UTC 2019 New revision: 492818 URL: https://svnweb.freebsd.org/changeset/ports/492818 Log: Undeprecate and retain GeoIP support by switching from net/GeoIP to net/libmaxminddb. Update pkg-message to document updating via net/geoipupdate. Remove pkg-descr whitespace flagged by portlint. PR: 234950 Reviewed by: ler (mentor) Approved by: firstname.lastname@example.org (maintainer), ler (mentor) Differential Revision: https://reviews.freebsd.org/D19173 Changes: head/dns/dsc/Makefile head/dns/dsc/files/pkg-message.in head/dns/dsc/pkg-descr