Bug 235111
| Summary: | add bectl support to beinstall.sh | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Olivier Cochard <olivier> | ||||||
| Component: | misc | Assignee: | Mateusz Piotrowski <0mp> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | 0mp, kevans, ler, will | ||||||
| Priority: | --- | ||||||||
| Version: | 12.0-RELEASE | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Remember to update the manual page as well! Created attachment 201311 [details]
patch to add bectl support and update man page
Here is the updated patch including man page update. I've removed reference to beadm into the man page to simplify it (even if the script still support it). This tool was added into FreeBSD 12.0, like bectl, so I don't think it's a problem to remove beadm reference.
Can an src committer push or approve it? Note: I've totally forgot about this PR and submitted my own patch a couple of months later to phabricator: https://reviews.freebsd.org/D21111 So let's abandon this PR and focus on your review :-) (In reply to Olivier Cochard from comment #5) OK :) Committed: https://reviews.freebsd.org/rS367159 |
Created attachment 201310 [details] patch to add bectl support beadm seems deprecated toward bectl, so here is a patch to add both support into beinstall.sh