Bug 235128

Summary: [PATCH] deskutils/xfce4-volumed: modernize and cleanup port
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Only Me CC: sergey.dyatko
Priority: --- Flags: bugzilla: maintainer-feedback? (sergey.dyatko)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Guido Falsi freebsd_committer freebsd_triage 2019-01-22 14:55:49 UTC
Created attachment 201332 [details]
patch

Hi,

I've committed a general cleanup and modernization patch for xfce ports in r490953.

I also made similar changes to deskutils/xfce4-volumed.

In particular:

- Added missing dependencies
- Added USES=gnome
- Cosmetic changes, like sorting things and reflowing OPTIONS related parts

Can you approve this patch?

Thanks.
Comment 1 Sergey V. Dyatko 2019-01-22 16:15:27 UTC
Looks good to me
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-22 18:51:25 UTC
A commit references this bug:

Author: madpilot
Date: Tue Jan 22 18:50:45 UTC 2019
New revision: 490973
URL: https://svnweb.freebsd.org/changeset/ports/490973

Log:
  - Add missing dependencies
  - Sort lists
  - Fix portlint warnings

  PR:		235128
  Submitted by:	myself
  Approved by:	Sergey V. Dyatko <sergey.dyatko@gmail.com> (Maintainer)

Changes:
  head/deskutils/xfce4-volumed/Makefile
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2019-01-22 18:51:33 UTC
Committed. Thanks!