Bug 235294
| Summary: | astro/opencpn: fix build with GCC-based architectures | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
| Component: | Individual Port(s) | Assignee: | Mark Linimon <linimon> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | linimon, ml | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(ml) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Sorry for taking so long. I have nothing against this patch: _ on amd64, the port compiles and runs with or without it; _ I don't have a PowerPC, so I cannot test this; I'll trust you it's required and it works. So, please, go ahead and commit it. Just out of curiosity why were gl and gnome added to USES? Probably it's my fault not putting them there in the first place, but I don't understand what they buy. Thanks. (In reply to ml from comment #1) They were added because it's now necessary to set USES=gl or USES=gnome when USE_GL or USE_GNOME is set. A commit references this bug: Author: linimon Date: Mon Feb 18 01:41:19 UTC 2019 New revision: 493234 URL: https://svnweb.freebsd.org/changeset/ports/493234 Log: GCC architectures don't support SSE, SSSE or AVX. Don't use them on GCC-based architectures to fix build. While here, set USES= gl gnome as per modern standards, and pet portlint. PR: 235294 Submitted by: Piotr Kubaj Approved by: portmgr (tier-2 blanket) Changes: head/astro/opencpn/Makefile |
Created attachment 201502 [details] patch GCC architectures don't support SSE, SSSE or AVX. Don't use them on GCC architectures to fix build. Tested on powerpc64 and amd64. Hardware sponsored by IntegriCloud.