Bug 235327
| Summary: | www/rubygem-passenger creates incorrect symlink | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dan Langille <dvl> |
| Component: | Individual Port(s) | Assignee: | Sergey A. Osokin <osa> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | dvl |
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(osa) |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235330 | ||
see also https://reviews.freebsd.org/D19034 A commit references this bug: Author: dvl Date: Wed Jan 30 19:35:11 UTC 2019 New revision: 491654 URL: https://svnweb.freebsd.org/changeset/ports/491654 Log: Install has a bug with relative links and is creating an incorrect symlink. Changing this to a full link. PR: 235327 Approved by: blanket approval MFH: 2019Q1 Changes: head/www/rubygem-passenger/Makefile A commit references this bug: Author: dvl Date: Wed Jan 30 21:29:47 UTC 2019 New revision: 491659 URL: https://svnweb.freebsd.org/changeset/ports/491659 Log: Fix the symlink to be relative. symlinks in PREFIX should always be relative. PR: 235327 Approved by: blanket approval MFH: 2019Q1 Changes: head/www/rubygem-passenger/Makefile A commit references this bug: Author: dvl Date: Wed Jan 30 22:59:32 UTC 2019 New revision: 491661 URL: https://svnweb.freebsd.org/changeset/ports/491661 Log: MFH: r491654 Install has a bug with relative links and is creating an incorrect symlink. Changing this to a full link. PR: 235327 Approved by: ports-secteam (joneum) Changes: _U branches/2019Q1/ branches/2019Q1/www/rubygem-passenger/Makefile see [[bugzilla:235330]] for install bug A commit references this bug: Author: dvl Date: Thu Jan 31 11:53:10 UTC 2019 New revision: 491709 URL: https://svnweb.freebsd.org/changeset/ports/491709 Log: MFH: r491659 Fix the symlink to be relative. symlinks in PREFIX should always be relative. PR: 235327 Approved by: ports-secteam (joneum) Changes: _U branches/2019Q1/ branches/2019Q1/www/rubygem-passenger/Makefile |
When running a testport based on head: $ cd /usr/local/libexec/apache24 $ ls -l mod_passenger.so lrwxr-xr-x 1 root wheel 74 Jan 2 11:32 mod_passenger.so -> ../../ruby/gems/2.4/gems/passenger-6.0.0/buildout/apache2/mod_passenger.so $ ls -l ../../ruby/gems/2.4/gems/passenger-6.0.0/buildout/apache2/mod_passenger.so ls: ../../ruby/gems/2.4/gems/passenger-6.0.0/buildout/apache2/mod_passenger.so: No such file or directory $ ls -l ../../lib/ruby/gems/2.4/gems/passenger-6.0.0/buildout/apache2/mod_passenger.so -rw-r--r-- 1 root wheel 1810776 Jan 2 11:32 ../../lib/ruby/gems/2.4/gems/passenger-6.0.0/buildout/apache2/mod_passenger.so [dvl@fmd-anacon-01stg:/usr/local/libexec/apache24] $ The current solution uses: ${INSTALL} -lrs ${STAGEDIR}${PREFIX}/${GEM_LIB_DIR}/buildout/apache2/mod_passenger.so ${STAGEDIR}${PREFIX}/${APACHEMODDIR}/mod_passenger.so My solution uses: ${LN} -sf ${PREFIX}/${GEM_LIB_DIR}/buildout/apache2/mod_passenger.so ${STAGEDIR}${PREFIX}/${APACHEMODDIR}/mod_passenger.so I also tried ${RLN} instead of '${INSTALL} -lrs' but that gets it wrong too. I think this is also an infrastructure bug, but in the short term, let's fix the port first?