Bug 235349

Summary: x11-fm/worker: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Mark Linimon <linimon>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, mp39590
Priority: --- Flags: bugzilla: maintainer-feedback? (mp39590)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-01-31 11:45:12 UTC
Created attachment 201558 [details]
patch

When compiling this port with GCC, the following warning is treated as error:
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

Add -Wno-error=narrowing to CXXFLAGS on GCC architectures to fix build.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-02-04 11:52:45 UTC
A commit references this bug:

Author: linimon
Date: Mon Feb  4 11:52:13 UTC 2019
New revision: 492118
URL: https://svnweb.freebsd.org/changeset/ports/492118

Log:
  When compiling this port with GCC, the following warning is treated as error:

    exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

  Add -Wno-error=narrowing to CXXFLAGS on GCC-based architectures to fix
  the build.

  PR:		235349
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/x11-fm/worker/Makefile