Bug 235393

Summary: lang/gcc8 (and all other lang/gcc* ports) need CONFIGURE_ARGS updated for powerpcspe
Product: Ports & Packages Reporter: Justin Hibbits <jhibbits>
Component: Individual Port(s)Assignee: Gerald Pfeifer <gerald>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Justin Hibbits freebsd_committer 2019-02-01 15:33:43 UTC
It seems the build of gcc* ports doesn't like the binutils update to 2.31, it now complains in the middle of the build (about 4 hours in) with a link-time build mismatch (some files built with double-precision floating point, other files with single-precision).  I think this is due to a quirk in the way gcc is built.

Someone did point out that the "--with-cpu=8540" is technically incorrect anyway, since we don't even support that platform in the first place.  The oldest platform we support for powerpcspe is the 8548. So changing

CONFIGURE_ARGS+= --with-cpu=8540....

to

CONFIGURE_ARGS+= --with-cpu=8548....

fixes the build, and everything is happy.

This may allow us to remove some CFLAGS, but I'm not concerned about that for now, and will adjust the flags in the system makefiles when I do get around to testing more.
Comment 1 Gerald Pfeifer freebsd_committer 2019-02-02 18:19:10 UTC
I'll make this change across all relevant ports over the next days;
thanks for the report.

(In the course of this I noticed an obsolete trace of powerpcspe in
lang/gcc9-devel which I'll remove as well since that codebase simply
does not have support anymore at all.)
Comment 2 commit-hook freebsd_committer 2019-02-03 07:05:15 UTC
A commit references this bug:

Author: gerald
Date: Sun Feb  3 07:04:21 UTC 2019
New revision: 492024
URL: https://svnweb.freebsd.org/changeset/ports/492024

Log:
  On powerpcspe configure GCC --with-cpu=8548 instead of --with-cpu=8540,
  which caused the build to fail after the update to binutils 2.31 and was
  factually incorrect anyways (the oldest we support being 8548). [1]

  On the way update to the 20180201 snapshot of GCC 8.2.1.

  PR:		235393 [1]
  Reported by:	jhibbits [1]
  Tested by:	jhibbits [1]

Changes:
  head/lang/gcc8-devel/Makefile
  head/lang/gcc8-devel/distinfo
Comment 3 commit-hook freebsd_committer 2019-02-04 09:41:26 UTC
A commit references this bug:

Author: gerald
Date: Mon Feb  4 09:40:34 UTC 2019
New revision: 492106
URL: https://svnweb.freebsd.org/changeset/ports/492106

Log:
  On powerpcspe configure GCC --with-cpu=8548 instead of --with-cpu=8540,
  which caused the build to fail after the update to binutils 2.31 and was
  factually incorrect anyways (since the oldest we support is 8548).

  PR:		235393
  Reported by:	jhibbits

Changes:
  head/lang/gcc5/Makefile
  head/lang/gcc6/Makefile
  head/lang/gcc7/Makefile
  head/lang/gcc7-devel/Makefile
  head/lang/gcc8/Makefile
Comment 4 Gerald Pfeifer freebsd_committer 2019-02-04 09:47:43 UTC
I think I caught everything, i.e., all regular lang/gcc* ports where
powerpcspe is listed as a platform.

Thanks for the report and suggested fix, Justin, and let me know if
there's anything more.
Comment 5 Justin Hibbits freebsd_committer 2019-02-04 16:03:05 UTC
Thanks for the quick fix, Gerald!
Comment 6 commit-hook freebsd_committer 2019-02-06 10:03:56 UTC
A commit references this bug:

Author: gerald
Date: Wed Feb  6 10:03:01 UTC 2019
New revision: 492297
URL: https://svnweb.freebsd.org/changeset/ports/492297

Log:
  Update to the 20190203 snapshot of GCC 9.0.1.

  Remove some last traces for powerpcspe support that I missed in r491253. [1]

  PR:		235393 [1]

Changes:
  head/lang/gcc9-devel/Makefile
  head/lang/gcc9-devel/distinfo