Bug 235482
| Summary: | net/libmaxminddb: use GCC on i386 since using clang generates an incorrect maxminddb_config.h | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ralf van der Enden <tremere> | ||||||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | tremere | ||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 235154 | ||||||||||
| Attachments: |
|
||||||||||
Try https://people.FreeBSD.org/~sunpoet/patch/net-libmaxminddb.txt instead of using GCC on i386. Created attachment 201763 [details]
Add sunpoet's patch to fix maxminddb_config.h on i386
Your patch works as expected, so redid my initial patch.
A commit references this bug: Author: sunpoet Date: Tue Feb 5 14:26:58 UTC 2019 New revision: 492238 URL: https://svnweb.freebsd.org/changeset/ports/492238 Log: Fix __int128 detection on i386 PR: 235482 Reported by: Ralf van der Enden <tremere@cainites.net> Changes: head/net/libmaxminddb/Makefile head/net/libmaxminddb/files/ head/net/libmaxminddb/files/patch-configure Committed. Thanks! Created attachment 235483 [details]
Poudriere Log
|
Created attachment 201710 [details] Change to GCC on i386 On i386 building with Clang gives you an incorrect include/maxminddb_config.h. configure tries to detect support for unsigned __int128 in two ways. The first one fails for both GCC and Clang, but the second is incorrectly detected as true by Clang. This can cause issues in packages depending on libmaxminddb (.ie security/modsecurity3) Bump portrevision because a new maxminddb_config.h needs to be generated on i386. Also petted portlint so it doesn't generate any errors anymore.