Bug 235644

Summary: irc/hexchat: Fails to build (if option python is off)
Product: Ports & Packages Reporter: Philipp Engel <kidon>
Component: Individual Port(s)Assignee: Koichiro Iwao <meta>
Status: Closed FIXED    
Severity: Affects Only Me CC: meta, pkubaj, w.schwarzenfeld
Priority: --- Flags: pkubaj: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
proposed-svn-diff-remove-python-option_v3 none

Description Philipp Engel 2019-02-10 16:29:03 UTC
Trying to build irc/hexchat 2.14.2_1 fails on FreeBSD 12.0-RELEASE-p2 (amd64) with Poudriere due to the following error:

===>  Building for hexchat-2.14.2_1
[1/67] /tmp/ports/usr/ports/irc/hexchat/work/hexchat-2.14.2/src/common/make-te.py ../src/common/textevents.in src/common/textevents.h src/common/textenums.h
FAILED: src/common/textevents.h src/common/textenums.h 
/tmp/ports/usr/ports/irc/hexchat/work/hexchat-2.14.2/src/common/make-te.py ../src/common/textevents.in src/common/textevents.h src/common/textenums.h
env: python3: No such file or directory
[2/67] /usr/local/bin/glib-genmarshal --prefix _hexchat_marshal --internal --output src/common/marshal.h --pragma-once --header ../src/common/marshalers.list
INFO: Reading ../src/common/marshalers.list...
[3/67] /usr/local/bin/glib-genmarshal --prefix _hexchat_marshal --internal --output src/common/marshal.c --body ../src/common/marshalers.list --include-header marshal.h
INFO: Reading ../src/common/marshalers.list...
[4/67] glib-compile-resources ../src/fe-gtk/../../data/hexchat.gresource.xml --sourcedir ../src/fe-gtk/../../data --sourcedir ../src/fe-gtk --c-name hexchat --internal --generate --target src/fe-gtk/resources.h --manual-register
[5/67] glib-compile-resources ../src/fe-gtk/../../data/hexchat.gresource.xml --sourcedir ../src/fe-gtk/../../data --sourcedir ../src/fe-gtk --c-name hexchat --internal --generate --target src/fe-gtk/resources.c --manual-register --dependency-file src/fe-gtk/resources.c.d
[6/67] cc -Iplugins/checksum/c016833@@checksum@sha -Iplugins/checksum -I../plugins/checksum -I. -I../ -Isrc/common -I../src/common -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu89 -O3 -fPIE -funsigned-char -Wno-conversion -Wno-pointer-sign -Wno-padded -Wno-unused-parameter -Wno-missing-prototypes -Winline -Wstrict-prototypes -Werror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self -Werror=missing-include-dirs -Werror=date-time -fstack-protector-strong -O2 -fstack-protector -fno-strict-aliasing -fPIC -DHAVE_CONFIG_H '-DHEXCHATLIBDIR="/usr/local/lib/hexchat/plugins"' -pthread  -MD -MQ 'plugins/checksum/c016833@@checksum@sha/checksum.c.o' -MF 'plugins/checksum/c016833@@checksum@sha/checksum.c.o.d' -o 'plugins/checksum/c016833@@checksum@sha/checksum.c.o' -c ../plugins/checksum/checksum.c
[7/67] /usr/local/bin/meson --internal msgfmthelper ../data/misc/io.github.Hexchat.appdata.xml.in data/misc/io.github.Hexchat.appdata.xml xml ../data/misc/../../po
[8/67] /usr/local/bin/meson --internal msgfmthelper data/misc/io.github.Hexchat.desktop.in data/misc/io.github.Hexchat.desktop desktop ../data/misc/../../po
ninja: build stopped: subcommand failed.
===> Compilation failed unexpectedly.

Options selected:
[ ] DBUS
[ ] DOCS
[ ] LUA
[ ] PERL
Comment 1 w.schwarzenfeld freebsd_triage 2019-02-10 19:35:30 UTC
Python has to be ON. Maybe the Python option should removed and set as LIB_DEPENDS. Or a change in meson.options or meson.build is needed.
Comment 2 Philipp Engel 2019-02-10 19:41:35 UTC
(In reply to w.schwarzenfeld from comment #1)
Can confirm, builds with PYTHON option.
Comment 3 w.schwarzenfeld freebsd_triage 2019-02-10 20:18:26 UTC
Created attachment 201904 [details]

Remove python option. Some changes cause of portlint.
Comment 4 Piotr Kubaj 2019-02-11 07:19:57 UTC
There's no Python 3.4 in ports anymore, so you could bump the required version to 3.5.

Other than that, it seems ok.
Comment 5 w.schwarzenfeld freebsd_triage 2019-02-11 10:11:59 UTC
Created attachment 201926 [details]

Correct python version.
Comment 6 Koichiro Iwao freebsd_committer 2019-02-11 15:23:15 UTC
plist issue found by poudriere.

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/hexchat/plugins/python.so
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%PYTHON%%lib/hexchat/plugins/python.so
===> Error: Plist issues found.
Comment 7 w.schwarzenfeld freebsd_triage 2019-02-11 16:19:49 UTC
Created attachment 201933 [details]
Comment 8 commit-hook freebsd_committer 2019-02-11 16:41:02 UTC
A commit references this bug:

Author: meta
Date: Mon Feb 11 16:40:07 UTC 2019
New revision: 492699
URL: https://svnweb.freebsd.org/changeset/ports/492699

  irc/hexchat: fix build when PYTHON option is off

  - hexchat requires Python 3
  - Specify PYTHON_VER in MESON_ARGS since each ports might be built with
    different Python versions

  PR:		235644
  Submitted by:	w.schwarzenfeld@utanet.at
  Reported by:	Philipp Engel <kidon@posteo.de>
  Approved by:	 Piotr Kubaj <pkubaj@anongoth.pl> (maintainer)

Comment 9 Koichiro Iwao freebsd_committer 2019-02-11 16:42:36 UTC
Committed, thanks!