Bug 235650
| Summary: | ports-mgmt/portlint: Should complain when {opt}_CMAKE_xx is set without USES=cmake | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||
| Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | adridg, marcus | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(marcus) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://reviews.freebsd.org/D19525 | ||||||
| Attachments: |
|
||||||
Patch to implement this put into Phab. Created attachment 203074 [details]
Add checks for {opt}_CMAKE without USES=cmake
Duplicate the patch that has been sitting in Phab.
A commit references this bug: Author: adridg Date: Fri Apr 5 12:08:54 UTC 2019 New revision: 497950 URL: https://svnweb.freebsd.org/changeset/ports/497950 Log: Add check for sensible CMAKE settings to ports-mgmt/portlint If a port sets CMAKE variables (CMAKE_ARGS, or the option helpers like foo_CMAKE_BOOL) then it should have USES=cmake; otherwise those variables don't make any sense. This is the slightly simplified version of the patch: there really shouldn't be options that switch (meta-)build systems. PORTREVISION bumped because I'm not sure what the versioning scheme is for portlint. PR: 235650 Reported by: yuri Approved by: marcus (maintainer timeout 2 weeks) Differential Revision: https://reviews.freebsd.org/D19525 Changes: head/ports-mgmt/portlint/Makefile head/ports-mgmt/portlint/src/portlint.pl A fix for this was just committed, and I folded it into my source tree. Looking to create a new release. |
Testcase: audio/fmit rev. 488406 It has no USES=cmake, and OSS_CMAKE_ON=, etc. portlint can easily detect that there's no cmake in any of USES= or {opt}_USES=, so it shouldn't allow {opt}_CMAKE_xx or just CMAKE_xx. portlint-2.18.8_1