|Summary:||graphics/mypaint: update to v2.0.0-alpha.8|
|Product:||Ports & Packages||Reporter:||Greg V <greg>|
|Component:||Individual Port(s)||Assignee:||Rodrigo Osorio <rodrigo>|
|Status:||In Progress ---|
|Severity:||Affects Only Me||CC:||gnome, kwm, rodrigo|
Description Greg V 2019-02-17 13:59:41 UTC
Created attachment 202094 [details] mypaint2.patch Now using Python 3 and installing with setuptools instead of scons. Old libmypaint and mypaint-brushes (used by graphics/gimp-app) are now with the '1' suffix.
Comment 1 Rodrigo Osorio 2019-06-05 14:51:27 UTC
@greg: wanna take maintenership for this port ?
Comment 3 Rodrigo Osorio 2019-06-05 15:16:18 UTC
The patch submitted is not correct : - the same patch impact multiple ports with multiple maintainers: * graphics/gimp-app * graphics/libmypaint * graphics/mypaint * graphics/mypaint-brushes This will increase de delay of adoption since we need approval for each port maintainer. At least you should better create one patch per port or a bug report per port and indicate the dependencies. - Some ports in your patch doesn't exists in ports tree: * graphics/libmypaint1 * graphics/mypaint-brushes1 If this is garbage, remove it from the final patch you submit.
Comment 4 Greg V 2019-06-05 15:19:37 UTC
(In reply to Rodrigo Osorio from comment #3) They're added by the patch > Old libmypaint and mypaint-brushes (used by graphics/gimp-app) are now with the '1' suffix. https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202094&action=diff#i/graphics/libmypaint1/Makefile_sec1 It doesn't really make sense to split it up, renaming the old version and introducing the new version should go in together
Comment 5 Rodrigo Osorio 2019-06-11 20:21:58 UTC
> They're added by the patch > > > Old libmypaint and mypaint-brushes > > (used by graphics/gimp-app) are now with the '1' suffix. My bad I didn't read your comments carefully enough. Nevertheless, you can't go that way so easily. 1st because 20+ packages has a direct dependency on mypaint-brushes, so you must provide a patch for all the ports who depends on, or request an exp-run to ensure moving to the new version doesn't break anything 2nd, libmypaint and mypaint-brushes maintainer has to approve the changes you suggest and validate the naming for the new port . I will recommend to start first with those two ports then see what the next step is.
Comment 6 Rodrigo Osorio 2019-08-22 12:14:36 UTC
Hi Greg, As said before, the submitted patch touch too many ports (graphics/gimp-app, graphics/libmypaint, graphics/libmypaint1, graphics/mypaint-brushes graphics/mypaint) and multiple maintainers. Furthermore, mypaint-brushes is a dependency for 20+ ports. I suggest you to create one PR per port to update, and use the 'depends on' fiels to link them. This way the ports maintainers can provide feedback on your patch.