Bug 235925

Summary: audio/pulseaudio: Remove option for installing completions
Product: Ports & Packages Reporter: Romain Tartière <romain>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me Flags: tobik: maintainer-feedback-
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Always install completions none

Description Romain Tartière freebsd_committer freebsd_triage 2019-02-21 21:27:36 UTC 
Created attachment 202242 [details]
Always install completions

Hi!

The ports currently does not align with what the porter's handbook says:

> When available, completion files should always be installed. It is not
> necessary to make an option for it. If an option is used, though, always enable
> it in OPTIONS_DEFAULT.

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#shell-completion

The attached patch drops the BASH and ZSH options to unconditionally install completion files.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-04-08 17:31:59 UTC 
A commit references this bug:

Author: tobik
Date: Mon Apr  8 17:31:20 UTC 2019
New revision: 498395
URL: https://svnweb.freebsd.org/changeset/ports/498395

Log:
  audio/pulseaudio: Always install shell completions per Porter's Handbook

  PR:		235925
  Submitted by:	romain
  Approved by:	gnome (maintainer timeout, a month)

Changes:
  head/audio/pulseaudio/Makefile
  head/audio/pulseaudio/pkg-plist