Bug 235926

Summary: audio/pulseaudio: Fix gsettings schema installation
Product: Ports & Packages Reporter: Romain Tartière <romain>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me Flags: tobik: maintainer-feedback-
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Rely on GLIB_SCHEMAS
none
Rely on GLIB_SCHEMAS none

Description Romain Tartière freebsd_committer freebsd_triage 2019-02-21 21:35:55 UTC
Created attachment 202243 [details]
Rely on GLIB_SCHEMAS

Schema should be installed with GLIB_SCHEMAS, otherwise glib-compile-schemas does not get called and the installed schema is non-functional.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-02-21 22:08:31 UTC
Comment on attachment 202243 [details]
Rely on GLIB_SCHEMAS

+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MGSETTINGS}
+GLIB_SCHEMAS=	org.freedesktop.pulseaudio.gschema.xml
+.endif
+

Please consider using an options helper for this instead:

GSETTINGS_VARS=	GLIB_SCHEMAS=org.freedesktop.pulseaudio.gschema.xml
Comment 2 Romain Tartière freebsd_committer freebsd_triage 2019-02-22 02:04:59 UTC
Created attachment 202249 [details]
Rely on GLIB_SCHEMAS

Good catch, I updated the patch accordingly.

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-08 17:25:50 UTC
A commit references this bug:

Author: tobik
Date: Mon Apr  8 17:25:03 UTC 2019
New revision: 498392
URL: https://svnweb.freebsd.org/changeset/ports/498392

Log:
  audio/pulseaudio: Fix gsettings schema installation

  Schema should be installed with GLIB_SCHEMAS, otherwise
  glib-compile-schemas does not get called and the installed schema
  is non-functional.

  PR:		235926
  Submitted by:	romain
  Approved by:	gnome (maintainer timeout, a month)

Changes:
  head/audio/pulseaudio/Makefile
  head/audio/pulseaudio/pkg-plist