Bug 235959

Summary:	DSACK not working
Product:	Base System	Reporter:	Richard Scheffenegger <rscheff>
Component:	kern	Assignee:	Michael Tuexen <tuexen>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	net, tuexen
Priority:	---	Flags:	tuexen: mfc-stable12+
Version:	CURRENT
Hardware:	Any
OS:	Any

Description Richard Scheffenegger freebsd_committer

2019-02-23 10:46:28 UTC

FreeBSD claims compliance with RFC2883 (DSACK) 
https://wiki.freebsd.org/action/login/TransportProtocols/tcp_rfc_compliance

but a recent test on HEAD does not show the transmission of DSACK blocks on deliberatly sent, duplicate data segments.

The bug may exist in older releases already, can not check currently.

tuexen@ may have an update on this too.

Comment 1 Michael Tuexen freebsd_committer

2019-06-20 07:55:59 UTC

This is fixed by:
https://svnweb.freebsd.org/changeset/base/347382
https://svnweb.freebsd.org/changeset/base/348728
and it was MFCed to stable/12 in
https://svnweb.freebsd.org/changeset/base/347902
https://svnweb.freebsd.org/changeset/base/349226