Bug 235969
| Summary: | net/frr6: integrated-vtysh-config not honored by rc file | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yakov Sh. <yman> | ||||||
| Component: | Individual Port(s) | Assignee: | Olivier Cochard <olivier> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(olivier) |
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Probably better check integrated config before starting daemons and reuse check_config function. Reupload patch. Created attachment 202349 [details]
updated patch
A commit references this bug: Author: olivier Date: Thu Mar 14 20:17:32 UTC 2019 New revision: 495731 URL: https://svnweb.freebsd.org/changeset/ports/495731 Log: Fix RC script when VTYSH (integrated configuration) mode is enabled PR: 235969 Submitted by: Yakov Sh. <yman@protonmail.ch> Changes: head/net/frr6/Makefile head/net/frr6/files/frr.in Thanks for your patch! |
Created attachment 202299 [details] frr.in.patch Problem When using 'integrated-vtysh-config' mode with frr.conf (frr_vtysh_boot rc flag), but without any daemon specific config files (e.g. ospfd.conf) all daemons failed to start. Then 'vtysh -b' failed to apply config to daemons. Steps to reproduce on 12.0: * install frr6 * create /usr/local/etc/frr/vtysh.conf with - service integrated-vtysh-config - hostname router - username root nopassword * create empty /usr/local/etc/frr/frr.conf * put any daemons in /etc/rc.conf options with frr_vtysh_boot, like - frr_enable="YES" - frr_daemons="zebra ospfd bgpd" - frr_vtysh_boot="YES" * start frr service Result No daemons running, service didn't start. Expected result All chosen daemons running, service started. Some explanation In 'integrated-vtysh-config' mode vtysh utility controls that all daemons has config they need, while serving it from single config file (frr.conf), not daemon specific configs. vtysh also controls config writing. Daemons on startup locate frr.conf file and don't tries to load they own config. 'vtysh -b' runs last and apply configuration to daemons. While there's a 'frr_vtysh_boot' flag in rc file for that exact reason, startup procedures still require all daemons have they own configs. If there are no daemon specific configs, that daemon will not be executed at all.