Bug 235981
| Summary: | [patch] lang/coffeescript: set NO_ARCH | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Samy Mahmoudi <samy.mahmoudi> | ||||||||
| Component: | Individual Port(s) | Assignee: | Vinícius Zavam <egypcio> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | araujo, beat, rene | ||||||||
| Priority: | --- | Keywords: | easy, patch | ||||||||
| Version: | Latest | Flags: | egypcio:
maintainer-feedback+
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Samy Mahmoudi
2019-02-24 02:44:11 UTC
Created attachment 202309 [details]
Patch file generated with svn diff
Created attachment 202310 [details]
Poudriere log
Created attachment 202314 [details]
Patch file generated with svn diff
(In reply to Samy Mahmoudi from comment #0) Set NO_ARCH. (In reply to Samy Mahmoudi from comment #4) Hi Samy, thank you for your patch! very appreciated. I'm gonna have a look and test it against 11, 12 and HEAD (in different architectures) and should report back to you as soon as possible :) KR, adding mentors in cc. There should be no reason to bump PORTREVISION, as the port itself does not change, it is only a tag for pkg(8). But bumping it won't hurt in this case either, as only 2 other ports use this port. (In reply to Vinícius Zavam from comment #5) You are welcome. (In reply to Rene Ladan from comment #7) Thank you for the information. Already used elsewhere, as in Bug 235982 ;-) (In reply to Rene Ladan from comment #7) as it takes some time to build, I would like to try avoiding the PORTREVISION bump. what do you think about it? this should help poudriere bulks to not waste time and resources building it (as we know that it's just a flag for pkg and does not really impact, help or change the port/package features anyway) (In reply to Samy Mahmoudi from comment #9) we are just waiting for approval, or an explicit rejection regarding your patch - it's just cosmetics, but I have nothing against pushing it to the tree. again, very appreciated for all your time and concern on sharing your patch with us. thanks! kr, Approved (I guess the concensus is to not bump PORTREVISION?) A commit references this bug: Author: egypcio Date: Thu Feb 28 09:18:06 UTC 2019 New revision: 494137 URL: https://svnweb.freebsd.org/changeset/ports/494137 Log: lang/coffeescript: set NO_ARCH - PORTREVISION was not bumped. PR: 235981 Submitted by: Samy Mahmoudi <samy.mahmoudi % gmail.com> Approved by: rene (mentor) Changes: head/lang/coffeescript/Makefile thank you everyone. appreciated! Thanks! |
