Bug 235991
| Summary: | sysutils/moosefs3-client: fix build with GCC-based architectures | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||
| Component: | Individual Port(s) | Assignee: | Mark Linimon <linimon> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | acid, freebsd, linimon, piotr.konopelko | ||||||
| Priority: | --- | Flags: | freebsd:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
I'm confused. There is no 'compiler:c11' in the patch. Created attachment 202329 [details]
patch
Sorry, it needed to be added to the master port.
Jakub @acid, Could you please take a look at this patch? Thanks, Piotr A commit references this bug: Author: linimon Date: Sun Mar 10 16:57:37 UTC 2019 New revision: 495300 URL: https://svnweb.freebsd.org/changeset/ports/495300 Log: Add compiler:c11 to USES to fix build on gcc-based architectures. PR: 235991 Submitted by: Piotr Kubaj Approved by: portmgr (tier-2 blanket) Changes: head/sysutils/moosefs3-master/Makefile Hello, Thanks for the patch. We were discussing it internally but I forgot to update this thread, I'm sorry. We tested this change on our builders and everything was built fine. We formally use gnu99 standard in MooseFS (not c11) and I wanted to ask, why there is "compiler:c11" in the patch and not something like "gcc >= 8"? (As stated in comment #0, CGG 8 doesn't seem to have this bug). Thanks, Piotr (In reply to Piotr Robert Konopelko (MooseFS) from comment #5) Adding USES=compiler is just a much simpler fix than adding .if block with USE_GCC. Besides, I'm not really sure whether it was fixed in GCC 8, or earlier. (In reply to Piotr Kubaj from comment #6) Thanks Piotr for clarification. Cheers, Piotr |
Created attachment 202322 [details] patch Add USES=compiler:c11 to fix build on GCC architectures. GCC 8 doesn't seem to have the bug that base GCC has. Tested on powerpc64 and amd64. Hardware sponsored by IntegriCloud.