Summary: | devel/json-cpp: Fix build with libc++ 8.0 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Dimitry Andric <dim> | ||||
Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | w.schwarzenfeld, yuri | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 236062 | ||||||
Attachments: |
|
Dimitry, I wouldn't have time for this any time soon. Please commit it as long as it doesn't break anything. Thanks, Yuri A commit references this bug: Author: dim Date: Tue Feb 26 19:08:43 UTC 2019 New revision: 493979 URL: https://svnweb.freebsd.org/changeset/ports/493979 Log: With libc++ 8.0, which is in the projects/clang800-import branch, and which will soon be merged to head, compilation of devel/jsoncpp fails due to a conflict between the new C++ <version> header, and a local file "version" which is produced by jsoncpp during its configure phase. This is due to the initial test runner being compiled with "-I.", even though it does not need any file from the port's working directory root. Therefore, it seems to be easiest to comment out the line from the SConstruct script that adds the "-I." option. Approved by: yuri (maintainer) PR: 236061 MFH: 2019Q1 Changes: head/devel/jsoncpp/Makefile head/devel/jsoncpp/files/patch-SConstruct Thanks Yuri, I committed the fix, and requested an MFH. (In reply to Dimitry Andric from comment #3) Thank you! A commit references this bug: Author: dim Date: Wed Feb 27 21:50:17 UTC 2019 New revision: 494088 URL: https://svnweb.freebsd.org/changeset/ports/494088 Log: MFH: r493979 With libc++ 8.0, which is in the projects/clang800-import branch, and which will soon be merged to head, compilation of devel/jsoncpp fails due to a conflict between the new C++ <version> header, and a local file "version" which is produced by jsoncpp during its configure phase. This is due to the initial test runner being compiled with "-I.", even though it does not need any file from the port's working directory root. Therefore, it seems to be easiest to comment out the line from the SConstruct script that adds the "-I." option. Approved by: portmgr (joneum) PR: 236061 Changes: _U branches/2019Q1/ branches/2019Q1/devel/jsoncpp/Makefile branches/2019Q1/devel/jsoncpp/files/patch-SConstruct |
Created attachment 202389 [details] Comment out line that produces "-I." With libc++ 8.0, which is in the projects/clang800-import branch, and which will soon be merged to head, compilation of devel/jsoncpp fails due to a conflict between the new C++ <version> header, and a local file "version" which is produced by jsoncpp during its configure phase. This is due to the initial test runner being compiled with "-I.", even though it does not need any file from the port's working directory root. Therefore, it seems to be easiest to comment out the line from the SConstruct script that adds the "-I." option.