Bug 236077

Summary: net/libjson-rpc-cpp: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Rodrigo Osorio <rodrigo>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, rodrigo, val
Priority: --- Flags: val: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-02-27 07:54:03 UTC
Created attachment 202404 [details]
patch

This port requires C++11-compatible compiler. Add USES=compiler:c++11-lang to fix build on GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Rodrigo Osorio freebsd_committer freebsd_triage 2019-03-06 15:48:15 UTC
Hi

The changes doesn't break builds with the default clang compiler but can you provide the logs of the tests or at least the methodology you uses to test the changes ?

Cheers,
- rodrigo
Comment 2 Val Packett 2019-03-07 00:28:49 UTC
(In reply to Rodrigo Osorio from comment #1)

Why would anything break from 'USES=compiler:c++11-lang'? The build process didn't change at all on non-GCC architectures.

That should've been there from the beginning, I just forget about gcc architectures when creating ports usually…
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-03-07 07:24:18 UTC
A commit references this bug:

Author: rodrigo
Date: Thu Mar  7 07:23:29 UTC 2019
New revision: 494914
URL: https://svnweb.freebsd.org/changeset/ports/494914

Log:
  Unbreak build on GCC architectures

  This port requires C++11-compatible compiler.
  Add USES=compiler:c++11-lang to fix build on GCC architectures.
  Bump PORTREVISION.

  PR:		236077
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/net/libjson-rpc-cpp/Makefile
Comment 4 Rodrigo Osorio freebsd_committer freebsd_triage 2019-03-07 07:39:05 UTC
Committed with minor changes, thanks.