Bug 236205
| Summary: | graphics/goxel: fails to build with clang 8 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
| Component: | Individual Port(s) | Assignee: | Jan Beich <jbeich> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | val, w.schwarzenfeld | ||||
| Priority: | --- | Keywords: | needs-patch | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(val) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 236062 | ||||||
| Attachments: |
|
||||||
Reminder: Clang 8 was merged to 13.0-CURRENT in base r344779. Maintainers, expect pkg-fallout@ mail soon. Created attachment 202691 [details]
goxel-werror.patch
damn Werror. let's disable it
compiler suggests checkliteral(S, &LUA_SIGNATURE [+ 1], "not a"); but it is only wanted to skip the first char, the simpelst is checkliteral(S, LUA_SIGNATURE [1], "not a"); this => checkliteral(S, LUA_SIGNATURE [1], "not a"); does not work. (I wanted to cancel comment3, but it was saved....). A commit references this bug: Author: jbeich Date: Thu Mar 7 20:56:48 UTC 2019 New revision: 495000 URL: https://svnweb.freebsd.org/changeset/ports/495000 Log: graphics/goxel: unbreak with clang 8 PR: 236205 Submitted by: Greg V (maintainer) Changes: head/graphics/goxel/Makefile |
$ poudriere jail -cj clang8 -v projects/clang800-import -m svn+https $ poudriere testport -j clang8 graphics/goxel [...] ext_src/lua/lundump.c:237:33: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int] checkliteral(S, LUA_SIGNATURE + 1, "not a"); /* 1st char already checked */ ~~~~~~~~~~~~~~^~~ ext_src/lua/lundump.c:237:33: note: use array indexing to silence this warning checkliteral(S, LUA_SIGNATURE + 1, "not a"); /* 1st char already checked */ ^ & [ ] 1 error generated. http://package18.nyi.freebsd.org/data/headamd64PR236062-default/2019-03-01_06h42m53s/logs/errors/goxel-0.8.2.log