Bug 236223

Summary:	sys.netpfil.pf.pass_block.nested_inline fails after r344720
Product:	Base System	Reporter:	Li-Wen Hsu <lwhsu>
Component:	tests	Assignee:	Kristof Provost <kp>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	---
Version:	CURRENT
Hardware:	Any
OS:	Any

Description Li-Wen Hsu freebsd_committer

2019-03-04 17:16:00 UTC

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/10369/testReport/sys.netpfil.pf/pass_block/nested_inline/

Original stderr
---------------

/usr/tests/sys/netpfil/pf/pass_block: vnet_mkepair: not found
ifconfig: interface a does not exist
/usr/tests/sys/netpfil/pf/pass_block: vnet_mkjail: not found
jexec: jail "alcatraz" is dying
jexec: jail "alcatraz" is dying
jexec: jail "alcatraz" is dying
jexec: jail "alcatraz" is dying
Fail: incorrect exit status: 2, expected: 0
stdout:
PING 192.0.2.2 (192.0.2.2): 56 data bytes

--- 192.0.2.2 ping statistics ---
1 packets transmitted, 0 packets received, 100.0% packet loss

It looks the code of vnet_mkepair and vnet_mkjail are not committed.

Comment 1 commit-hook freebsd_committer

2019-03-04 18:15:51 UTC

A commit references this bug:

Author: kp
Date: Mon Mar  4 18:15:09 UTC 2019
New revision: 344764
URL: https://svnweb.freebsd.org/changeset/base/344764

Log:
  tests: Move common (vnet) test functions into a common file

  The netipsec and pf tests have a number of common test functions. These
  used to be duplicated, but it makes more sense for them to re-use the
  common functions.

  PR:		236223

Changes:
  head/tests/sys/Makefile
  head/tests/sys/common/
  head/tests/sys/common/Makefile
  head/tests/sys/common/vnet.subr
  head/tests/sys/netipsec/tunnel/utils.subr
  head/tests/sys/netpfil/pf/anchor.sh
  head/tests/sys/netpfil/pf/forward.sh
  head/tests/sys/netpfil/pf/fragmentation.sh
  head/tests/sys/netpfil/pf/names.sh
  head/tests/sys/netpfil/pf/nat.sh
  head/tests/sys/netpfil/pf/pass_block.sh
  head/tests/sys/netpfil/pf/pfsync.sh
  head/tests/sys/netpfil/pf/rdr.sh
  head/tests/sys/netpfil/pf/route_to.sh
  head/tests/sys/netpfil/pf/set_skip.sh
  head/tests/sys/netpfil/pf/set_tos.sh
  head/tests/sys/netpfil/pf/synproxy.sh
  head/tests/sys/netpfil/pf/utils.subr

Comment 2 Kristof Provost freebsd_committer

2019-03-04 18:17:52 UTC

That was indeed the problem. I had a local commit to unify some of the netipsec and pf test support code, and forgot to undo those changes in the new test.

I've now committed the missing commit, so the tests should start passing again. I'll close this when the ci system does the next build without issue.

Comment 3 Li-Wen Hsu freebsd_committer

2019-03-04 18:22:30 UTC

Thanks, I was filing this ticket as a place to track failing case while compiling the last CI report.

Comment 4 commit-hook freebsd_committer

2019-03-09 10:35:19 UTC

A commit references this bug:

Author: kp
Date: Sat Mar  9 10:34:45 UTC 2019
New revision: 344966
URL: https://svnweb.freebsd.org/changeset/base/344966

Log:
  MFC r344764

  tests: Move common (vnet) test functions into a common file

  The netipsec and pf tests have a number of common test functions. These
  used to be duplicated, but it makes more sense for them to re-use the
  common functions.

  PR:		236223

Changes:
_U  stable/12/
  stable/12/tests/sys/Makefile
  stable/12/tests/sys/common/
  stable/12/tests/sys/netipsec/tunnel/utils.subr
  stable/12/tests/sys/netpfil/pf/anchor.sh
  stable/12/tests/sys/netpfil/pf/forward.sh
  stable/12/tests/sys/netpfil/pf/fragmentation.sh
  stable/12/tests/sys/netpfil/pf/names.sh
  stable/12/tests/sys/netpfil/pf/nat.sh
  stable/12/tests/sys/netpfil/pf/pass_block.sh
  stable/12/tests/sys/netpfil/pf/pfsync.sh
  stable/12/tests/sys/netpfil/pf/rdr.sh
  stable/12/tests/sys/netpfil/pf/route_to.sh
  stable/12/tests/sys/netpfil/pf/set_skip.sh
  stable/12/tests/sys/netpfil/pf/set_tos.sh
  stable/12/tests/sys/netpfil/pf/synproxy.sh
  stable/12/tests/sys/netpfil/pf/utils.subr