Bug 236227
| Summary: | net-mgmt/nagios-check_smartmon for changed smartctl output | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dan Langille <dvl> | ||||||
| Component: | Individual Port(s) | Assignee: | Dan Langille <dvl> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | pi, pierre, ports | ||||||
| Priority: | --- | Flags: | ports:
maintainer-feedback+
koobs: merge-quarterly+ |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236873 | ||||||||
| Attachments: |
|
||||||||
Created attachment 202560 [details]
the patched files/patch-check_smartmon file
I have also uploaded files/patch-check_smartmon after it has been patched.
Comment on attachment 202559 [details]
patch to the port
ok
For me it is OK. I am trying to keep this backwards compatible. I would feel better committing this after I run it for a bit longer at home. It's on all my servers. I'd also like to have feedback from others using the patch in the field. I'm hoping Pierre Guinoiseau gets back to me re: https://lists.freebsd.org/pipermail/svn-ports-all/2019-February/208453.html The patch works for me! On a server with real disks: $ sudo python2.7 /usr/local/libexec/nagios/check_smartmon -w 45 -c 60 -d /dev/ada0 OK: device is functional and stable (temperature: 39) On a virtual machine with a virtual disk: $ sudo python2.7 /usr/local/libexec/nagios/check_smartmon -w 45 -c 60 -d /dev/da0 OK: device is functional and stable (temperature: 0) Thanks! A commit references this bug: Author: dvl Date: Fri Mar 8 21:59:56 UTC 2019 New revision: 495081 URL: https://svnweb.freebsd.org/changeset/ports/495081 Log: Catch up with smartctl changes while retaining old behaviour. PR: 236227 Approved by: Krzysztof <ports@bsdserwis.com> (maintainer) MFH: 2019Q1 Changes: head/net-mgmt/nagios-check_smartmon/Makefile head/net-mgmt/nagios-check_smartmon/files/patch-check_smartmon Thank you for your help. A commit references this bug: Author: dvl Date: Sat Mar 9 23:26:08 UTC 2019 New revision: 495215 URL: https://svnweb.freebsd.org/changeset/ports/495215 Log: MFH: r495081 Catch up with smartctl changes while retaining old behaviour. PR: 236227 Approved by: Krzysztof <ports@bsdserwis.com> (maintainer) Approved by: ports-secteam (miwi) Changes: _U branches/2019Q1/ branches/2019Q1/net-mgmt/nagios-check_smartmon/Makefile branches/2019Q1/net-mgmt/nagios-check_smartmon/files/patch-check_smartmon |
Created attachment 202559 [details] patch to the port The patches are still not complete. smartctl output varies. This is a SATA devices, which because of camcontrol, appears as a SCSI device when connected to an HBA as da3: 194 Temperature_Celsius 0x0022 100 100 000 Old_age Always - 43 (Min/Max 7/60) This is also a SATA device, which is connected directly to the motherboard as ada0: 194 Temperature_Internal 0x0022 100 100 000 Old_age Always - 25 The attached patch attempts to do the right thing, even when attribute 194 is not present.