Bug 236245

Summary: net-mgmt/cnagios: Update to 0.33, Add FLAVORS
Product: Ports & Packages Reporter: gettoknowmi <gettoknowmi>
Component: Individual Port(s)Assignee: Dan Langille <dvl>
Status: In Progress ---    
Severity: Affects Some People CC: danny, dvl, meta, w.schwarzenfeld
Priority: --- Keywords: needs-qa
Version: LatestFlags: bugzilla: maintainer-feedback? (danny)
Hardware: Any   
OS: Any   
Description Flags
add flavors
Update to 0.33, Add FLAVORS
koobs: maintainer-approval? (danny)
Update to 0.33, Add FLAVORS, mention flavors in pkg-descr dvl: maintainer-approval?

Description gettoknowmi 2019-03-05 09:07:06 UTC
change run depends to latest nagios version
Index: net-mgmt/cnagios/Makefile
--- net-mgmt/cnagios/Makefile	(revision 484897)
+++ net-mgmt/cnagios/Makefile	(working copy)
@@ -10,7 +10,8 @@
-RUN_DEPENDS=	nagios>=3.0:net-mgmt/nagios
+# local change so this port installs nagios3, not nagios3
+RUN_DEPENDS=	nagios4>=4.0:net-mgmt/nagios4
Comment 1 Koichiro Iwao freebsd_committer 2019-03-11 05:46:19 UTC
Comment 2 Dan Langille freebsd_committer 2019-03-21 19:50:13 UTC
Would a new port, perhaps net-mgmt/cnagios4, be more appropriate?
Comment 3 Dan Langille freebsd_committer 2019-03-21 19:59:12 UTC
(In reply to Dan Langille from comment #2)
If so, I am happy to create that new port, which could be a slave of this.
Comment 4 Dan Langille freebsd_committer 2019-03-22 12:34:52 UTC
(In reply to Dan Langille from comment #3)
I briefly considered adding configuration options to allow either nagios3 or nagios4, but then I realized I need both.

I will create net-mgmt/cnagios4
Comment 5 commit-hook freebsd_committer 2019-03-22 13:23:17 UTC
A commit references this bug:

Author: dvl
Date: Fri Mar 22 13:22:41 UTC 2019
New revision: 496565
URL: https://svnweb.freebsd.org/changeset/ports/496565

  Add cnagios4, based on net-mgmt/cnagios but uses Nagios 4

  Why not create options on net-mgmt/cnagios for Nagios 3 or 4?

  Because one can use both Nagios 3 and Nagios 4 and therefore
  you need different packages in your repo.

  PR:		236245

Comment 6 Dan Langille freebsd_committer 2019-03-22 13:25:20 UTC
net-mgmt/cnagios4 created after offline consultation with gettoknowmi
Comment 7 Dan Langille freebsd_committer 2019-03-22 17:35:04 UTC
Created attachment 203046 [details]
add flavors

I have added a patch which introduces FLAVORS

* @nagios3 (default)
* @nagios4

For portlint:

* move USES up in Makefile
* add a WWW link to pkg-descr

Tests have been carried out with poudriere testport with:

* no flavor
* @nagios3
* @nagios4
Comment 8 Dan Langille freebsd_committer 2019-03-22 17:36:14 UTC
With this patch, I propose to delete net_mgmt/cnagios4 because it would no longer be required.

Danny: please let me know what you think.  Thank you.
Comment 9 Dan Langille freebsd_committer 2019-03-22 17:49:51 UTC
Created attachment 203047 [details]
Update to 0.33, Add FLAVORS

I amended the original patch to upgrade to 0.33, released Aug 2016

Comment 10 Dan Langille freebsd_committer 2019-03-25 12:38:09 UTC
Proceeding based up on maintainer timeout, given no response since this ticket was opened 20 days ago.
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2019-03-25 12:47:06 UTC
@Dan Timeouts are based on the date of the (latest) proposed patch. I'd give maintainer 14 days to accept (or not) attachment 203047 [details] on that basis, after which time it can be / is implicitly Approved by: portmgr (timeout, > 14 days)
Comment 12 Dan Langille freebsd_committer 2019-03-25 14:11:27 UTC
@(In reply to Kubilay Kocak from comment #11)

via IRC last night, I got word from portmgr that timeout had already occurred.  I need to write to portmgr to get FLAVOR approval anyway.  I will ask for clarification regarding timeout.   Thank you.
Comment 13 Dan Langille freebsd_committer 2019-03-25 14:23:54 UTC
Created attachment 203134 [details]
Update to 0.33, Add FLAVORS, mention flavors in pkg-descr

I have updated the patch:

* to use flavor_PKGNAMESUFFIX
* mention the flavors in pkg-descr
Comment 14 Walter Schwarzenfeld freebsd_triage 2019-08-16 00:48:31 UTC
Maintainer timeout!
Comment 15 Dan Langille freebsd_committer 2019-09-25 13:42:43 UTC
I asked portmgr@freebsd.org for permission to commit this flavor but did not hear back. I have asked them again.