Bug 236290
| Summary: | [PATCH] multimedia/gstreamer1-transcoder: add DOCS option | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ivan Rozhuk <rozhuk.im> | ||||||||
| Component: | Individual Port(s) | Assignee: | Koop Mast <kwm> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | jcfyecrayz, rozhuk.im, swills, tcberner | ||||||||
| Priority: | --- | Flags: | rozhuk.im:
maintainer-feedback-
rozhuk.im: merge-quarterly? |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 202604 [details]
gtkdoc opt
This should be DOCS, not GTKDOC Created attachment 212396 [details]
patch
(In reply to Steve Wills from comment #2) Using DOCS implies a default-on condition. I think that's appropriate for pre-generated docs. Pulling in gtkdoc and generating docs at build time may not be a good default-on option. This is the same reason DOXYGEN is often a separate option (and is off by default). Most end-users don't care about the generated API docs. Some ports explicitly turn off gtkdoc generation and don't even provide an option to turn it on. I think it's okay, perhaps better, to use a GTKDOC option that is off by default. Whoever commits this might consider using the GTKDOC flavor of the patch. Oh, and... maintainer timeout? maintainer timeout There is 2 patch: DOCS and GTKDOC choose one. Committed. Thanks. A commit references this bug: Author: tcberner Date: Tue Dec 22 17:29:19 UTC 2020 New revision: 558928 URL: https://svnweb.freebsd.org/changeset/ports/558928 Log: multimedia/gstreamer1-transcoder: add DOCS option PR: 236290 Submitted by: rozhuk.im@gmail.com Changes: head/multimedia/gstreamer1-transcoder/Makefile head/multimedia/gstreamer1-transcoder/pkg-plist |
Created attachment 202603 [details] gtkdoc opt