Bug 236351
| Summary: | games/ponscripter-sekai: fix build on powerpc, powerpc64 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||||
| Component: | Individual Port(s) | Assignee: | Jan Beich <jbeich> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | linimon, pkubaj | ||||||||
| Priority: | --- | Flags: | jbeich:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | http://pylon.nyi.freebsd.org/data/head-powerpc64-default/p495218_s344972/logs/errors/ponscripter-sekai-0.0.6_6.log | ||||||||||
| Attachments: |
|
||||||||||
-maltivec is already passed. Can you show build log to better understand the cause?
configure:
xppc) USE_PPC_GFX=true
GFX_MALTIVEC_FLAGS="-maltivec -DUSE_PPC_GFX"
GFX_EXT_OBJS="graphics_altivec.o"
CFLAGSEXTRA="$CFLAGSEXTRA -DUSE_PPC_GFX"
echo " Compiling with PPC custom graphics routines";;
[...]
elif $USE_PPC_GFX
then
cat >> $MAKEFILE <<_EOF
graphics_altivec.o: graphics_altivec.cpp graphics_altivec.h graphics_common.h
\$(CXX) \$(CXXSTD) \$(PSCFLAGS) \$(INCS) \$(DEFS) $GFX_MALTIVEC_FLAGS -c \$< -o \$@
_EOF
Created attachment 202854 [details]
log
Is a build log straight from the ports tree ok?
Comment on attachment 202679 [details]
patch
No good.
It builds every file with -maltivec which obviously won't work if CPU on which the binary package is run doesn't support AltiVec.
AltiVec isn't actually used because runtime detection is only implemented for macOS thus only AnimationInfo::CPUF_NONE is returned. multimedia/libvpx has example for VSX which should be easy to adjust for AltiVec or macOS code can be used after s/hw.optional.altivec/hw.altivec/.
A commit references this bug: Author: jbeich Date: Thu Mar 14 19:42:29 UTC 2019 New revision: 495727 URL: https://svnweb.freebsd.org/changeset/ports/495727 Log: games/ponscripter-sekai: unbreak on powerpc64 g++8 -O2 -pipe -Wl,-rpath=/usr/local/lib/gcc8 -Wl,-rpath=/usr/local/lib/gcc8 -c -Wall -DUSE_PPC_GFX -I/usr/local/include/SDL2 -I/usr/local/include -D_REENTRANT -D_THREAD_SAFE -I/usr/local/include -I/usr/local/include/smpeg2 -I/usr/local/include/SDL2 -I/usr/local/include -D_REENTRANT -D_THREAD_SAFE -I/usr/local/include/freetype2 -DLINUX -DUSE_OGG_VORBIS -DCONST_ICONV graphics_altivec.cpp In file included from graphics_altivec.cpp:29: /usr/local/lib/gcc8/gcc/powerpc64-portbld-freebsd13.0/8.3.0/include/altivec.h:34:2: error: #error Use the "-maltivec" flag to enable PowerPC AltiVec support #error Use the "-maltivec" flag to enable PowerPC AltiVec support ^~~~~ PR: 236351 Reported by: Piotr Kubaj, pkg-fallout Changes: head/games/ponscripter-sekai/Makefile head/games/ponscripter-sekai/distinfo Piotr, does the committed fix work for you? If so close the bug. Created attachment 202857 [details]
standalone test
A commit references this bug: Author: jbeich Date: Thu Mar 14 20:48:03 UTC 2019 New revision: 495733 URL: https://svnweb.freebsd.org/changeset/ports/495733 Log: games/ponscripter-sekai: oops, fix __FreeBSD__ >= 12 check FreeBSD 12+ should use elf_aux_info(3) as it caches CPU features. PR: 236351 Changes: head/games/ponscripter-sekai/Makefile A commit references this bug: Author: jbeich Date: Thu Mar 14 20:50:48 UTC 2019 New revision: 495734 URL: https://svnweb.freebsd.org/changeset/ports/495734 Log: games/ponscripter-sekai: unbreak after r495733 => No SHA256 checksum recorded for 25e752f272d0.patch. => No suitable checksum found for 25e752f272d0.patch. PR: 236351 Pointy hat to: jbeich Changes: head/games/ponscripter-sekai/distinfo At least it builds now. http://pylon.nyi.freebsd.org/data/head-powerpc64-default/p496011_s345238/logs/ponscripter-sekai-0.0.6_6.log A commit references this bug: Author: jbeich Date: Thu Mar 21 00:13:14 UTC 2019 New revision: 496396 URL: https://svnweb.freebsd.org/changeset/ports/496396 Log: MFH: r494759 r495727 r495733 r495734 games/ponscripter-sekai: unbreak on powerpc64 gmake[2]: *** No rule to make target 'graphics_maltivec.o', needed by 'ponscr'. Stop. g++8 -O2 -pipe -Wl,-rpath=/usr/local/lib/gcc8 -Wl,-rpath=/usr/local/lib/gcc8 -c -Wall -DUSE_PPC_GFX -I/usr/local/include/SDL2 -I/usr/local/include -D_REENTRANT -D_THREAD_SAFE -I/usr/local/include -I/usr/local/include/smpeg2 -I/usr/local/include/SDL2 -I/usr/local/include -D_REENTRANT -D_THREAD_SAFE -I/usr/local/include/freetype2 -DLINUX -DUSE_OGG_VORBIS -DCONST_ICONV graphics_altivec.cpp In file included from graphics_altivec.cpp:29: /usr/local/lib/gcc8/gcc/powerpc64-portbld-freebsd13.0/8.3.0/include/altivec.h:34:2: error: #error Use the "-maltivec" flag to enable PowerPC AltiVec support #error Use the "-maltivec" flag to enable PowerPC AltiVec support ^~~~~ PR: 236351 Reported by: Piotr Kubaj, pkg-fallout Approved by: ports-secteam-blanket Changes: _U branches/2019Q1/ branches/2019Q1/games/ponscripter-sekai/Makefile branches/2019Q1/games/ponscripter-sekai/distinfo |
Created attachment 202679 [details] patch Add -maltivec to CXXFLAGS on powerpc and powerpc64 to fix build. While here, also add USES=sdl. Hardware sponsored by IntegriCloud.