Bug 236448

Summary: audio/musicpd: Fix build VORBIS=off, VORBISENC=on
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: riggs
Priority: --- Keywords: patch
Version: LatestFlags: riggs: maintainer-feedback+
riggs: merge-quarterly?
Hardware: Any   
OS: Any   
Attachments:
Description Flags
musicpd.diff tobik: maintainer-approval? (riggs)

Description Tobias Kortkamp freebsd_committer 2019-03-10 12:26:28 UTC
Created attachment 202772 [details]
musicpd.diff

mpd does not support enabling VORBISENC while VORBIS is disabled.
Update options accordingly.

Dependency vorbis skipped: feature vorbis disabled
Dependency vorbisidec skipped: feature tremor disabled

src/lib/xiph/meson.build:15:4: ERROR:  Problem encountered: Cannot build the Vorbis encoder without the Vorbis decoder
Comment 1 commit-hook freebsd_committer 2019-03-11 11:37:10 UTC
A commit references this bug:

Author: riggs
Date: Mon Mar 11 11:37:05 UTC 2019
New revision: 495349
URL: https://svnweb.freebsd.org/changeset/ports/495349

Log:
  Fix vorbis dependencies: VORBISENC implies VORBIS

  PR:		236448
  Submitted by:	tobik
  MFH:		2019Q1

Changes:
  head/audio/musicpd/Makefile
Comment 2 commit-hook freebsd_committer 2019-03-11 11:42:16 UTC
A commit references this bug:

Author: riggs
Date: Mon Mar 11 11:41:34 UTC 2019
New revision: 495350
URL: https://svnweb.freebsd.org/changeset/ports/495350

Log:
  MFH: r495349

  Fix vorbis dependencies: VORBISENC implies VORBIS

  PR:		236448
  Submitted by:	tobik

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2019Q1/
  branches/2019Q1/audio/musicpd/Makefile
Comment 3 Thomas Zander freebsd_committer 2019-03-11 11:46:37 UTC
Committed, thanks!