Summary: | periodic.sh: Anticongestion function does not work as is expected. | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Yasuhiro Kimura <yasu> | ||||
Component: | bin | Assignee: | Alan Somers <asomers> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | asomers, imp, jamie, pi, rgrimes, seanc | ||||
Priority: | --- | Flags: | asomers:
mfc-stable12+
asomers: mfc-stable11+ |
||||
Version: | CURRENT | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Yasuhiro Kimura
2019-03-16 01:12:31 UTC
The patch looks good to my eye, but I have no ability to test it. This bug is on no lists, could it please be re-triaged and put onto some list in the CC: field. I would do it but I am not sure what list best applies to this specific bug and leave that to the experts to decide. Thanks, Rod rod: you're free to add it to the right list if you know it, but Alan has grabbed the bug, and I have to presume he's clueful enough to involve the proper people. A commit references this bug: Author: asomers Date: Sun Aug 18 17:12:06 UTC 2019 New revision: 351192 URL: https://svnweb.freebsd.org/changeset/base/351192 Log: periodic: fix anticongestion for scripts run after security Revision 316342, which introduced the anticongestion feature, failed to consider that the periodic scripts are executed by a recursive invocation of periodic. The recursive invocation wrongly cleaned up a temporary file that should've been cleaned up only by the original invocation. The result is that if the first script that requests an anticongestion sleep runs after the security scripts, the sleep won't happen. Fix this bug by delaying cleanup until the end of the original invocation. PR: 236564 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> Reviewed by: imp MFC after: 1 month Changes: head/usr.sbin/periodic/periodic.sh Thanks for spotting this, Yasuhiro. I'll MFC in a month and then we'll be all done. (In reply to Alan Somers from comment #5) Hello Alan. Would you please MFC to stable/12 before branching releng/12.1? Best Regards. A commit references this bug: Author: asomers Date: Wed Sep 18 17:18:09 UTC 2019 New revision: 352489 URL: https://svnweb.freebsd.org/changeset/base/352489 Log: MFC r351192, r351203 r351192: periodic: fix anticongestion for scripts run after security Revision 316342, which introduced the anticongestion feature, failed to consider that the periodic scripts are executed by a recursive invocation of periodic. The recursive invocation wrongly cleaned up a temporary file that should've been cleaned up only by the original invocation. The result is that if the first script that requests an anticongestion sleep runs after the security scripts, the sleep won't happen. Fix this bug by delaying cleanup until the end of the original invocation. PR: 236564 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> Reviewed by: imp r351203: periodic: replace "tty" with "test -t 0" Apparently using tty for this purpose has been deprecated since 4.4 Lite. Reviewed by: cy Differential Revision: https://reviews.freebsd.org/D21318 Changes: _U stable/12/ stable/12/usr.sbin/periodic/periodic.sh A commit references this bug: Author: asomers Date: Wed Sep 18 17:21:34 UTC 2019 New revision: 352490 URL: https://svnweb.freebsd.org/changeset/base/352490 Log: MFC r351192, r351203 r351192: periodic: fix anticongestion for scripts run after security Revision 316342, which introduced the anticongestion feature, failed to consider that the periodic scripts are executed by a recursive invocation of periodic. The recursive invocation wrongly cleaned up a temporary file that should've been cleaned up only by the original invocation. The result is that if the first script that requests an anticongestion sleep runs after the security scripts, the sleep won't happen. Fix this bug by delaying cleanup until the end of the original invocation. PR: 236564 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> Reviewed by: imp r351203: periodic: replace "tty" with "test -t 0" Apparently using tty for this purpose has been deprecated since 4.4 Lite. Reviewed by: cy Differential Revision: https://reviews.freebsd.org/D21318 Changes: _U stable/11/ stable/11/usr.sbin/periodic/periodic.sh Done! Thanks for your contribution. A commit references this bug: Author: asomers Date: Sun Sep 22 00:12:44 UTC 2019 New revision: 352588 URL: https://svnweb.freebsd.org/changeset/base/352588 Log: MF stable/12 r352489 Approved by: re (kib) r351192: periodic: fix anticongestion for scripts run after security Revision 316342, which introduced the anticongestion feature, failed to consider that the periodic scripts are executed by a recursive invocation of periodic. The recursive invocation wrongly cleaned up a temporary file that should've been cleaned up only by the original invocation. The result is that if the first script that requests an anticongestion sleep runs after the security scripts, the sleep won't happen. Fix this bug by delaying cleanup until the end of the original invocation. PR: 236564 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> Reviewed by: imp r351203: periodic: replace "tty" with "test -t 0" Apparently using tty for this purpose has been deprecated since 4.4 Lite. Reviewed by: cy Differential Revision: https://reviews.freebsd.org/D21318 Changes: _U releng/12.1/ releng/12.1/usr.sbin/periodic/periodic.sh |