Bug 236648
| Summary: | [patch] net/onedrive make OPTIONS really work | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Hiroo Ono <hiroo.ono+freebsd> | ||||||
| Component: | Individual Port(s) | Assignee: | Koichiro Iwao <meta> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | hiroo.ono+freebsd, meta | ||||||
| Priority: | --- | Flags: | meta:
maintainer-feedback?
(hiroo.ono+freebsd) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
lang/dmd2 is deprecated and will be expired in May. Please do not depend on the port. Please don't forget bump PORTREVISION when you make changes on dependency. Created attachment 203724 [details]
net/onedrive/Makefile update.
Thank you for your comment. I updated the patch.
- Removed options and changed to depend only on lang/ldc.
- Bumped PORTREVISON to 1.
Do I need to add NOT_FOR_ARCHS? Due to lang/ldc building only on amd64, this port is also limited to amd64.
A commit references this bug: Author: meta Date: Mon Apr 22 08:04:53 UTC 2019 New revision: 499611 URL: https://svnweb.freebsd.org/changeset/ports/499611 Log: net/onedrive: remove dependency on deprecated port lang/dmd2 is marked DEPRECATED. Remove dependency on that. PR: 236648 Submitted by: Hiroo Ono <hiroo.ono+freebsd@gmail.com> (maintainer) Changes: head/net/onedrive/Makefile Committed, thanks! Probably it would be nice to declare ONLY_FOR_ARCHS or NOT_FOR_ARCHS. |
Created attachment 202990 [details] correct the port's Makefile. I did test building it on i386. I found that: * OPTIONS did not take effect (always depended on lang/ldc). * It cannot be built with dmd1. The patch corrects above problems. Tested with pourdriere on stable/12 i386 and amd64. I should have done that before submitting the port. Sorry. Effectively, neither dmd2 nor ldc builds on i386 (and non-x86), the fact that only amd64 version may be used do not change.