Bug 236730

Summary: x11/eaglemode: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, pkubaj
Priority: --- Flags: bugzilla: maintainer-feedback? (amdmi3)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-03-23 08:38:20 UTC
Created attachment 203064 [details]
patch

LDFLAGS, when using ports GCC, has a space at the beginning, which eaglemode has problem with. Add correct LDFLAGS (without the space in the beginning) so that the port builds.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2019-03-28 16:08:50 UTC
This is incorrect in many ways like you may not override LDFLAGS and you may not hardcode /usr/local. Code should be fixed instead to handle whitespace correctly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-03-28 16:09:56 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Mar 28 16:08:53 UTC 2019
New revision: 497026
URL: https://svnweb.freebsd.org/changeset/ports/497026

Log:
  Don't generate empty arguments when parsing CFLAGS/CXXFLAGS/LDFLAGS

  PR:		236730
  Submitted by:	pkubaj@anongoth.pl

Changes:
  head/x11/eaglemode/files/patch-makers_unicc_plugins_unicc__gnu.pm