Bug 236774
| Summary: | security/keepassxc: Fails to build with KEESHARE option disabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Guido Falsi <madpilot> | ||||
| Component: | Individual Port(s) | Assignee: | Guido Falsi <madpilot> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | melanhit | ||||
| Priority: | --- | Keywords: | easy, needs-qa | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(melanhit) madpilot: merge-quarterly- |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/keepassxreboot/keepassxc/commit/eb9ff677d0c681a86a9ef296f5a363549b94c42c | ||||||
| Attachments: |
|
||||||
Created attachment 203119 [details]
patch
patch was lost for some reason in submission.
Comment on attachment 203119 [details]
patch
Approved by: portmgr (blanket: bugfix, build/run fix)
Version in 2019Q1 is not affected, does not have the KEESHARE option. A commit references this bug: Author: madpilot Date: Mon Mar 25 09:36:32 UTC 2019 New revision: 496805 URL: https://svnweb.freebsd.org/changeset/ports/496805 Log: Import upstream paatch which fixes build when KEESHARE is disabled. PR: 236774 Submitted by: myself Approved by: portmgr (blanket: bugfix, build/run fix) Obtained from: https://github.com/keepassxreboot/keepassxc/commit/eb9ff677d0c681a86a9ef296f5a363549b94c42c Changes: head/security/keepassxc/files/patch-src_gui_DatabaseWidget.cpp Committed with blanket approval. |
As stated in the subject I noticed keepassxc fails with the KEESHARE option disabled with the following error: /wrkdirs/usr/ports/security/keepassxc/work/keepassxc-2.4.0/src/gui/DatabaseWidget.cpp:1115:5: error: use of undeclared identifier 'm_shareLabel' m_shareLabel->setVisible(false); ^ 1 error generated. I have found a commit upstream addressing this: https://github.com/keepassxreboot/keepassxc/commit/eb9ff677d0c681a86a9ef296f5a363549b94c42c Attaching a patch including this patch in the port.