Bug 236891
| Summary: | lang/lua53: move assertion to correct place | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andrew "RhodiumToad" Gierth <andrew> | ||||
| Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | russ.haley | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(russ.haley) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Thanks for this. I'm not sure I agree about the port revision number. I would think it should be updated irrespective of the users being affected. Do you care particularly one way or the other? (In reply to Russell Haley from comment #1) I don't feel too strongly about it, but consider that it does not affect the package build (since asserts are off by default) and only a vanishingly tiny proportion of users should even be enabling them. Putting out an updated package with no actual changes seems undesirable. A commit references this bug: Author: swills Date: Fri May 3 11:50:25 UTC 2019 New revision: 500722 URL: https://svnweb.freebsd.org/changeset/ports/500722 Log: lang/lua53: move assertion to correct place PR: 236891 Submitted by: andrew@tao11.riddles.org.uk Approved by: Russell Haley <russ.haley@gmail.com> (maintainer) Changes: head/lang/lua53/Makefile head/lang/lua53/files/extra-patch-assert Committed, thanks! |
Created attachment 203251 [details] patch extra-patch-assert to move an incorrectly placed assertion Per discussion on lua-l, the first assert in atomic() is misplaced and can cause false failures; this patch moves it (only when asserts are enabled) to the correct place. This fix only affects assertion-enabled builds (which is not the default) and only in relatively rare cases, so I think that PORTREVISION should probably not be updated. I submit it anyway because as far as I know there are no plans for an upstream fix.