Bug 236975

Summary: audio/bcg729 is no longer installs libdata/pkgconfig/libbcg729.pc since upgrade to 1.0.4 (rev.482343)
Product: Ports & Packages Reporter: Maxim Sobolev <sobomax>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Only Me CC: sobomax, tijl
Priority: --- Flags: madpilot: maintainer-feedback+
madpilot: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to fix the issue. none

Description Maxim Sobolev freebsd_committer freebsd_triage 2019-04-02 23:08:31 UTC
Created attachment 203332 [details]
Patch to fix the issue.

Upgrade to the 1.0.4 switched to cmake for no particular reason and as a result lost libdata/pkgconfig/libbcg729.pc, which may be used by other packages (e.g. net/rtpproxy) to detect if bcg729 library is present. This patch restores that functionality, PORTREVISION is bumped to reflect that change.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2019-04-03 07:06:41 UTC
Thanks for the patch!

I'm testing it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-03 09:42:00 UTC
A commit references this bug:

Author: madpilot
Date: Wed Apr  3 09:41:17 UTC 2019
New revision: 497702
URL: https://svnweb.freebsd.org/changeset/ports/497702

Log:
  Add back libdata/pkgconfig/libbcg729.pc file after it was removed
  by the 1.0.4 update in r482343.

  PR:		236975
  Submitted by:	sobomax
  MFH:		2019Q2

Changes:
  head/audio/bcg729/Makefile
  head/audio/bcg729/pkg-plist
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2019-04-03 09:42:11 UTC
Committed. Thanks!

I also intend to merge this to quarterly.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-04-05 15:17:07 UTC
A commit references this bug:

Author: madpilot
Date: Fri Apr  5 15:17:00 UTC 2019
New revision: 497964
URL: https://svnweb.freebsd.org/changeset/ports/497964

Log:
  MFH: r497702

  Add back libdata/pkgconfig/libbcg729.pc file after it was removed
  by the 1.0.4 update in r482343.

  PR:		236975
  Submitted by:	sobomax

  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2019Q2/
  branches/2019Q2/audio/bcg729/Makefile
  branches/2019Q2/audio/bcg729/pkg-plist
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2019-04-05 15:18:24 UTC
Merged to quarterly.