Bug 237051
| Summary: | Skip sys/geom/class/mirror/component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Olivier Cochard <olivier> | ||||||
| Component: | tests | Assignee: | Olivier Cochard <olivier> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | asomers, emaste, imp, markj, ngie | ||||||
| Priority: | --- | ||||||||
| Version: | 12.0-RELEASE | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236841 | ||||||||
| Attachments: |
|
||||||||
Comment on attachment 203412 [details]
Patch to skip tests if geom_nop not available
The patch looks good to me. But shouldn't that test also be loading the gmirror module?
Created attachment 203413 [details]
patch to tests for g_mirror and g_nop availability
Yes, good idea!
Hi, does the updated patch please you? (In reply to Olivier Cochard from comment #3) LGTM! Also, please feel free to use Phabricator next time -- it's better for managing diff review. This looks good to me and should be committed. Following emaste's comment on IRC, I've re-organized function in alphabetical order. And here is the review on phabricator: https://reviews.freebsd.org/D19958 A commit references this bug: Author: olivier Date: Tue Apr 23 21:07:47 UTC 2019 New revision: 346605 URL: https://svnweb.freebsd.org/changeset/base/346605 Log: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available PR: 237051 Reviewed by: asomers, imp, ngie, emaste (IRC) Approved by: ngie MFC after: 1 month Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D19958 Changes: head/tests/sys/geom/class/mirror/component_selection.sh Waiting on MFC The test in question isn't in stable/12. |
Created attachment 203412 [details] Patch to skip tests if geom_nop not available This test script is using geom_nop, so reuse the same function (load_gnop) as in geom/class/nop/nop_test to skip this test if geom_nop is not available.