Bug 23712

Summary: Unused variable CDB in /usr/src/usr.sbin/pw/Makefile
Product: Base System Reporter: stolz <stolz>
Component: binAssignee: dd <dd>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.2-STABLE   
Hardware: Any   
OS: Any   

Description stolz 2000-12-21 14:20:00 UTC
/usr/src/usr.sbin/pw/Makefile includes the uninitialized variable CDB into CFLAGS:

#RND=   -DUSE_MD5RAND
CFLAGS+= -W -Wall $(CDB) $(RND)

This will lead to problems when the user invoking make (e.g. on ´make world´)
has set this particular variable in his environment. It should be set to a
reasonable default (empty: "") or be dropped altogether.

On a related note, the assignment to RND in the same Makefile is commented out.
To avoid the same problem as mentioned above with CDB it should at least
be set to "".

Fix: 

Two possible solutions for CDB:
1) Drop it from the Makefile
2) Set it to ""

For RND:
Set to "".
How-To-Repeat: Enter /usr/src/usr.sbin/pw, set CDB or RND to some arbitrary value, invoke make.
Comment 1 dd freebsd_committer freebsd_triage 2001-06-19 01:39:31 UTC
State Changed
From-To: open->analyzed

Committed, thanks! 


Comment 2 dd freebsd_committer freebsd_triage 2001-06-19 01:39:31 UTC
Responsible Changed
From-To: freebsd-bugs->dd

My MFC reminder.
Comment 3 dd freebsd_committer freebsd_triage 2001-07-02 02:13:14 UTC
State Changed
From-To: analyzed->closed

MFC'd some time ago.