Bug 237129
| Summary: | sys.netmap.ctrl-api-test.main fails on ^/stable/11 and ^/stable/12 i386 because the kernel lacks netmap support | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Enji Cooper <ngie> |
| Component: | tests | Assignee: | Enji Cooper <ngie> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | lwhsu, olivier, testing, vmaffione |
| Priority: | --- | Flags: | ngie:
mfc-stable12?
ngie: mfc-stable11? ngie: mfc-stable10- |
| Version: | CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
| See Also: | https://reviews.freebsd.org/D19864 | ||
|
Description
Enji Cooper
2019-04-09 01:04:27 UTC
I see the same issue with ^/stable/11. What is the best way to solve it ? 1. Adding a kernel FEATURE(netmap,"...") declaration and check for this in the test? 2. Checking for /dev/netmap in the test script ? (In reply to Olivier Cochard from comment #2) The best way to solve this is to check for the kernel module. netmap(4) doesn't have any kernel features associated with it, so adding a check wouldn't do much good. I'll have a patch out soon for this. A commit references this bug: Author: ngie Date: Tue Apr 9 17:52:12 UTC 2019 New revision: 346061 URL: https://svnweb.freebsd.org/changeset/base/346061 Log: Polish netmap(4) testcases a bit 1. Not all kernels have netmap(4) support. Check for netmap(4) support before attempting to run the tests via the `PLAIN_REQUIRE_KERNEL_MODULE(..)` macro. 2. Libraries shouldn't be added to LDFLAGS; they should be added to LIBADD instead. This allows the build system to evaluate dependencies for sanity. 3. Sort some of the Makefile variables per bsd.README. 1., in particular, will resolve failures when running this testcase on kernels lacking netmap(4) support, e.g., the i386 GENERIC kernels on ^/stable/11 and ^/stable/12. PR: 237129 Reviewed by: vmaffione Approved by: emaste (mentor) MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D19864 Changes: head/tests/sys/netmap/Makefile head/tests/sys/netmap/ctrl-api-test.c A commit references this bug: Author: ngie Date: Tue Apr 16 01:03:33 UTC 2019 New revision: 346256 URL: https://svnweb.freebsd.org/changeset/base/346256 Log: MFC r345644,r346061: r345644 (by olivier): Skip this test if if_tap module is not available PR: 236842 r346061: Polish netmap(4) testcases a bit 1. Not all kernels have netmap(4) support. Check for netmap(4) support before attempting to run the tests via the `PLAIN_REQUIRE_KERNEL_MODULE(..)` macro. 2. Libraries shouldn't be added to LDFLAGS; they should be added to LIBADD instead. This allows the build system to evaluate dependencies for sanity. 3. Sort some of the Makefile variables per bsd.README. 1., in particular, will resolve failures when running this testcase on kernels lacking netmap(4) support, e.g., the i386 GENERIC kernels on ^/stable/11 and ^/stable/12. PR: 237129 Changes: _U stable/11/ stable/11/tests/sys/netmap/Makefile stable/11/tests/sys/netmap/ctrl-api-test.c A commit references this bug: Author: ngie Date: Tue Apr 16 01:03:38 UTC 2019 New revision: 346257 URL: https://svnweb.freebsd.org/changeset/base/346257 Log: MFC r345644,r346061: r345644 (by olivier): Skip this test if if_tap module is not available PR: 236842 r346061: Polish netmap(4) testcases a bit 1. Not all kernels have netmap(4) support. Check for netmap(4) support before attempting to run the tests via the `PLAIN_REQUIRE_KERNEL_MODULE(..)` macro. 2. Libraries shouldn't be added to LDFLAGS; they should be added to LIBADD instead. This allows the build system to evaluate dependencies for sanity. 3. Sort some of the Makefile variables per bsd.README. 1., in particular, will resolve failures when running this testcase on kernels lacking netmap(4) support, e.g., the i386 GENERIC kernels on ^/stable/11 and ^/stable/12. PR: 237129 Changes: _U stable/12/ stable/12/tests/sys/netmap/Makefile stable/12/tests/sys/netmap/ctrl-api-test.c |