Bug 237132
| Summary: | devel/tcl-trf: crc-zlib broken | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | regulaar |
| Component: | Individual Port(s) | Assignee: | Mikhail Teterin <mi> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | freebsd-2024, mi |
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(freebsd-2024) |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
A commit references this bug: Author: mi Date: Thu Apr 11 04:37:43 UTC 2019 New revision: 498636 URL: https://svnweb.freebsd.org/changeset/ports/498636 Log: The below-mentioned PR identified a problem, which should've been caught by the test-harness -- but was not, because the harness was not used correctly (for 10 years). Provide a new harness and fix the reported problem as well as another one -- with MD2 digests -- identified by the now-functioning test-suit. Bump PORTREVISION... PR: 237132 Reported by: Vadim Zborovsky Changes: head/devel/tcl-trf/Makefile head/devel/tcl-trf/files/alltests.tcl head/devel/tcl-trf/files/patch-md2 head/devel/tcl-trf/files/patch-zlib All should be fixed now. Many thanks for raising awareness! |
crc-zlib is broken in devel/tcl-trf after port rev. 482639. Proof: % package require Trf 2.1.4 % set chk [crc-zlib {Hello, World!}] % binary scan $chk i chksum 1 % format 0x%x $chksum 0x0 But we should get something different: https://wiki.tcl-lang.org/page/Trf Apparently this is introduced in the following lines in patch-zlib: 190 - CRC = zf.zcrc32 (CRC, buffer, bufLen); 191 + CRC = crc32(0L, Z_NULL, 0); No data are ever CRC'd here. For Adler checksum things are better: 48 - ADLER = zf.zadler32 (ADLER, buffer, bufLen); 49 + ADLER = adler32 (ADLER, buffer, bufLen); I hope no other filters are affected.